[HOLD for payment 2024-04-15] [$500] Chat - App shows skeleton loading after clicking on message link

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.56-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to any chat
3. Send a message
4. Right click on the message > Copy link
5. Paste it in the same chat and send the link
6. Click on the link

Expected Result:

App will directly show the linked message without loading. Note that this is only the expected behavior if:

• the reportAction being linked to is already loaded in Onyx
• the reportAction being linked to is part of the currently-loaded continuous chain of reportActions. i.e: if you are in the middle of a chat, and have multiple pages of actions not yet loaded between where you are and the most recent chat, then you click on a link to the newest chat, it would be expected that the chat would "refresh" close to the front.

Actual Result:

App shows skeleton loading after clicking on the link

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6423378_1711125463057.20240323_000900.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0102c76546294661c9
• Upwork Job ID: 1775293847501484032
• Last Price Increase: 2024-04-02
• Automatic offers:
• ikevin127 | Contributor | 0

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @puneetlath (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

@puneetlath FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[perunt]

We do OpenReport on each link to ensure that we have appropriate data. Therefore, you the loader/skeleton appears

[puneetlath]

It sounds like this is the expected behavior for now, so going to close this out.

[roryabraham]

Reopening this with clarified expected behavior

[melvin-bot]

Current assignee @puneetlath is eligible for the NewFeature assigner, not assigning anyone new.

[roryabraham]

@perunt do you want to handle this as part of the comment linking follow-up? I'd be happy to make it external but would love to have the PR to fix this create some automated UI tests to cover these edge cases which are difficult to test manually. Since you have the best context it might be easier for you to write these tests.

[perunt]

Sure, @roryabraham. I'll handle that and throw in some extra tests today to make sure nothing breaks it down with the next PRs.

[roryabraham]

This was fixed in #39166, looks like payment is due to @ikevin127 for the C+ review

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0102c76546294661c9

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

[melvin-bot]

📣 @ikevin127 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[roryabraham]

ok @puneetlath, the only payment that's due here is to @ikevin127 for their review of #39166

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Linking without loader #39166

If no regressions arise, payment will be issued on 2024-04-15. 🎊

For reference, here are some details about the assignees on this issue:

• @perunt does not require payment (Contractor)
• @ikevin127 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ikevin127] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[ikevin127]

• [@ikevin127] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.

Q #38813 (comment):

do you want to handle this as part of the comment linking follow-up?

A #38813 (comment)

Sure. I'll handle that and throw in some extra tests today to make sure nothing breaks it down with the next PRs.

Based on the above context, I don't think we need any regression test as this fix was part of the comment linking follow-up.

[puneetlath]

All paid. Thanks everyone!