[$500] Distance - Distance editor still shows new waypoint after dismissing the editor without saving

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.56-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4444296
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat
3. Create a distance request
4. Go to request details page
5. Click Distance
6. Add another waypoint
7. Click outside the distance editor to dimiss it instead of saving the edit
8. Click Distance

Expected Result:

The distance editor will not show the new waypoint added in Step 6 because the edit is not saved

Actual Result:

The distance editor still shows the new waypoint despite not saving the edit

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6423673_1711138556384.20240323_041104.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015105b9d7569afcfa
• Upwork Job ID: 1772360813317861376
• Last Price Increase: 2024-04-01
• Automatic offers:
• cubuspl42 | Contributor | 0
• DylanDylann | Contributor | 0

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[lanitochka17]

@marcaaron FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[marcaaron]

I don't think this need to block the deploy.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015105b9d7569afcfa

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mkhutornyi (External)

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[paultsimura]

It looks like a regression from #34610, the fix should be in the making already.

[greg-schroeder]

Checking to see if that's the case, and will close if so as this is already being resolved.

[DylanDylann]

Fixing here

[mkhutornyi]

Looks like this is being fixed already but in case C+ is needed, please reassign.
I am currently sick.

[cubuspl42]

@DylanDylann As #38911 is now closed, would you link the new PR, possibly draft?

[DylanDylann]

@cubuspl42 It is a bit complicated, I will raise PR today

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[cubuspl42]

We have a draft PR, Melvin; there won't be any proposals

[greg-schroeder]

Work on linked PR continues

[greg-schroeder]

Looks like @cubuspl42 and @puneetlath were involved in the linked PR, so assigning you both

[greg-schroeder]

Looks like this PR is fixing 3 separate GHs:

#35173
#38853
#38864

[greg-schroeder]

Hmm - how are we handling payments here as there are multiple regressions involved. :/ I'm going to cancel these automatic offers for now so we can get on the same page.

[cubuspl42]

@greg-schroeder This issue can be closed, from my perspective. The original issue is...

• [Pay 4/29][$250] Remove NewDistanceRequestPage.js and copy any changes since Nov 27 into IOURequestStepDistance.js #34610

[greg-schroeder]

Okay got it - yeah, I think this is the regression issue so we'll handle payments in the original. If anyone disagrees, please reopen this.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.