-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] [HOLD for payment 2024-04-05] Workspace - One of the dropdown options configured in OD is missing from ND #38898
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Triggered auto assignment to @aldo-expensify ( |
We think that this bug might be related to #wave-collect - Release 1 |
ProposalPlease re-state the problem that we are trying to solve in this issue.One of the dropdown options configured in OD is missing from ND What is the root cause of that problem?We send wrong information to the component in the prop What changes do you think we should make in order to solve the problem?We must send all the value Note In my opinion we should disable the search functionality for dropdown if the list is less than 8 in length, this is consistent with categories and tags Result |
ProposalPlease re-state the problem that we are trying to solve in this issue.Workspace - One of the dropdown options configured in OD is missing from ND What is the root cause of that problem?here when we filtering App/src/pages/EditReportFieldPage.tsx Line 109 in 00e0121
and this the value of values and disabledOptions
this logic is incorrect, because the keyword
so What changes do you think we should make in order to solve the problem?we need to change the filter logic to be
What alternative solutions did you explore? (Optional)we can edit disabledOptions in the backend to be string[] and use |
Note In my proposal, i mentioned that we should Also this behavior is consistent with the tags and category list as well, we pass all the values to the component and then filter them accordingly |
I think @ahmedGaber93 is right about the problem being the usage of the |
hmm I don't think we necessarily have to be consistent with the CategoryPicker, that seems to be dealing with many specific things related to categories and is more complex. I think it is fine for the design of |
As i said the |
hmmmmmmm that is an interesting case, let me see... |
I'm testing your PR, i'll put up a video there if i found this bug true :) |
I tested and it doesn't seem to cause a problem. If the selected options is not within the list passed to Screen.Recording.2024-03-25.at.1.09.32.PM.mov |
Oh great then!! we're good to go i guess |
In your screenshot, the recent show 2 and 3, were any of those disabled? |
I had disabled the 2nd option |
I think you are right about that there is a problem with the "Recent" options. They should be filtered down by the available (enabled) options too, right? App/src/pages/EditReportFieldDropdownPage.tsx Lines 92 to 104 in 4caf61a
|
I guess so, but we both are getting different results on disabling dropdowns so i am assuming there is some different settings for both of us |
I reproduced the "Recent" options bug offering me a disabled option and I fixed it here @GandalfGwaihir @ahmedGaber93 do you both agree with sharing the reward for fixing this? This would be 250/250? I think both helped sufficiently to split it. |
Fine with me :), wbu @ahmedGaber93 ? |
@aldo-expensify fine with me. |
When are you merging this PR? I am having second thoughts about filtering at the prop level, will do some testing ?! Or even a Follow up PR would be sound |
Why is that? do you think there may be another bug? |
hmm maybe we should do a useMemo around |
Removing Deploy blocker label, the issue is fixed now |
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-04-05. 🎊 |
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO. |
@ahmedGaber93 and i are due payment for this issue according to this comment, c.c. @aldo-expensify @kevinksullivan |
friendly bump for payment @kevinksullivan , summary over here |
Job added to Upwork: https://www.upwork.com/jobs/~01286e42f8805eb5ba |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 ( |
just using |
job created and offer sent to @ahmedGaber93 . Couldn't find @GandalfGwaihir so can you let me know when you apply and I will pay this out? Thanks! |
all set |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.56.0
Reproducible in staging?: y
Reproducible in production?: new feature
Issue reported by:
Action Performed:
Expected Result:
All options should be visible.
Actual Result:
One of the dropdown option configured in OD is missing from ND. In this instance, it's "2".
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
bandicam.2024-03-24.00-09-12-512.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @kevinksullivanUpwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: