-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-04-25] [$500] Workspace - The user can skip validation of the first name field on the Personal info tab #38920
Comments
Triggered auto assignment to @johncschuster ( |
We think this issue might be related to the #collect project. |
ProposalPlease re-state the problem that we are trying to solve in this issue.The user can skip the legal name form after filling the last name, go back and reconfirm the routing number again. What is the root cause of that problem?We have App/src/pages/ReimbursementAccount/utils/getInitialSubstepForPersonalInfo.ts Lines 9 to 16 in 4bc6744
If the first name and last name are empty, we will show the legal name form. However, if we fill in the last name, it will be saved to the draft and we check for both draft and server value
and the condition will fail because it needs both fields to be empty. What changes do you think we should make in order to solve the problem?Show the legal name form if one of the first or last names is empty.
What alternative solutions did you explore? (Optional)Don't check for the draft data.
OR Always starts from 0 (the legal name form).
|
Job added to Upwork: https://www.upwork.com/jobs/~01c8adbf72aee79603 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane ( |
I'm not sure how this fits into any of our existing initiatives, but this feels like either an oversight or a regression if the user can skip ahead of entering their first name in the form. |
Thanks for the proposal @bernhardoj. Proposal from @bernhardoj looks good to me. 🎀 👀 🎀 C+ reviewed |
Triggered auto assignment to @grgia, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
@johncschuster, @sobitneupane, @grgia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
PR is ready cc: @sobitneupane |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.62-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-04-25. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Payment Summary:@sobitneupane - $500 - via NewDot Manual Requests |
@sobitneupane, can you complete the BZ Checklist above? Thank you! |
@johncschuster, @sobitneupane, @grgia, @bernhardoj Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Waiting on the BZ Checklist to be completed 👍 |
@johncschuster, @sobitneupane, @grgia, @bernhardoj Eep! 4 days overdue now. Issues have feelings too... |
Yes.
|
Regression Test Proposal
|
Requested payment in newDot. |
$500 approved for @sobitneupane |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.56.0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4445017&group_by=cases:section_id&group_id=283225&group_order=asc
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal Team
Action Performed:
Expected Result:
The field should be validated.
Actual Result:
The user can skip validation of the first name field on the Personal info tab. "Bank account can't be created, firstName is invalid or missing" error message appears later in the flow.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6424896_1711259142194.XKMK1639.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @sobitneupaneThe text was updated successfully, but these errors were encountered: