[HOLD for payment 2024-04-15] [$500] Web - Group chat - Unable to create a group chat via search input after deselecting members

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.58-0
Reproducible in staging?: y
Reproducible in production?: n
Issue found when executing PR: #37458
Issue reported by: Applause _ Internal Team

Action Performed:

1. Click on FAB > Start a chat > Select multiple users either from existing contact or by using the search bar
2. Go to the next step
3. Deselect all the previously added group contacts
4. Go back to the previous page
5. Try the add to group method to add contacts and confirm that works
6. Deselect any members added
7. Try to search for a new contact using the search field
8. Click on add to group once the contact shows up
9. Search for another contact and click on add to group
10. Clear the search field to see the selected contacts
11. Once again do step 7, step 8 and step 9
12. Click on create a chat and observe the new created chat avatar and header

Expected Result:

The two contacts added on step 7, step 8 and step 9 should be added and be present in the selected list

Actual Result:

No contacts are visible as being selected to be in the group and once done with step 12 the created chat shows a group chat avatar while it is a chat between 1:1 DM.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6431961_1711739235908.bandicam_2024-03-29_21-55-39-449.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017b977d3a359504bf
• Upwork Job ID: 1775337898141978624
• Last Price Increase: 2024-04-03

[melvin-bot]

Triggered auto assignment to @marcochavezf (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kbecciv]

We think that this bug might be related to #vip-vsb

[marcochavezf]

It looks like this is coming up with a new functionality for Group chats, which was recently implemented: #39295. So it shouldn't be a deploy blocker

[marcaaron]

Thanks @marcochavezf if you want me to take over feel free to assign! No problem 👍

[marcochavezf]

Ok sounds good, assigning it to you!

[marcaaron]

@s77rt lmk if you want to work on this one with me?

[s77rt]

@marcaaron Sure! Will look into this asap

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017b977d3a359504bf

[melvin-bot]

Current assignee @s77rt is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[marcaaron]

@s77rt helped us fix this and raised the PR. There was no other C+ on this one.

[s77rt]

This issue can be closed. Payment will be handled in the original issue

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Group chat: Use draft only on init and on draft changes #39312

If no regressions arise, payment will be issued on 2024-04-15. 🎊

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

• The PR that introduced the bug has been identified: Create Group Chats + Splits. #37458
• The offending PR has been commented on: Create Group Chats + Splits. #37458 (comment)
• A discussion in #expensify-bugs has been started: Not needed (unique bug)
• Determine if we should create a regression test for this bug: No (not something that could just resurface)