-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pay meow][$250] Make the app splash screen look the same on all platforms #39369
Comments
Triggered auto assignment to @mallenexpensify ( |
cc @Expensify/design for vis too |
ProposalPlease re-state the problem that we are trying to solve in this issue.Change the splash background on web to match the mobile experience. What is the root cause of that problem?New change. What changes do you think we should make in order to solve the problem?We need to change the colour in
splash-logo is defined in webpack.common.ts. We will need to add the updated assets there.
|
|
Job added to Upwork: https://www.upwork.com/jobs/~0105d7830f9d724cc5 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane ( |
@grgia I made this |
Yeah let's make it external @mallenexpensify ! |
Current assignee @rushatgabhane is eligible for the External assigner, not assigning anyone new. |
@ShridharGoel on native, could you please make sure that the notification status bar is also theme dependent? |
@rushatgabhane Status bar colour is set as transparent: |
oh awesome! |
@ShridharGoel's proposal LGTM 🎀 👀 🎀 |
Current assignee @grgia is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new. |
📣 @ShridharGoel 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
@shawnborton Can you confirm that #03D47C (light theme) and #061B09 (dark theme) are the correct colours? |
Cool, I could definitely get down with green as the best option here. |
Is it okay to add new logos by directly editing the colours in existing
SVGs?
…On Mon, Apr 8, 2024, 8:05 PM Shawn Borton ***@***.***> wrote:
Cool, I could definitely get down with green as the best option here.
—
Reply to this email directly, view it on GitHub
<#39369 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIPLJHD4ERQ6TWD2ZFGEMO3Y4KTLJAVCNFSM6AAAAABFR3HWJWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBSHEZDCMJXG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Probably? I guess we need to decide if we want to keep the staging and dev subscript text on these during start up... mobile currently does not have them, but all other platforms do. So if that's the case, the design team can help create new assets with the correct colors there given that the green we use for "STG" is quite similar to the green we'd be using for the background. |
Makes sense, so how can we decide whether "DEV" and "STG" are needed? |
Also, DEV and STG are for internal use and not for customers, so I think it should be fine even if they match a little to the background. |
We currently do this on web/mWeb. |
Yeah, so I was just asking about how can we decide whether to keep them or not since you mentioned the below:
|
Let's get confirmation from the entire @Expensify/design that we want to move forward with a green BG, and if so, I'll update this issue so we can get proposals based on our new solution. From here, the design team can provide the correct assets needed. |
ProposalUpdated to make the web splash theme same as mobile. |
Thanks Shawn. I'm okay with this as well. Sounds like the best compromise. |
Okay I've updated the title and description of the bug. The replacement assets to use are here: SplashAssets.zip |
Thanks, will open a PR soon. |
PR on production last week - #39997 (comment) @mallenexpensify please attach payment summary when you can, thank you : ) |
Manual request here - https://staging.new.expensify.com/r/7309992663381871 |
@mallenexpensify can I get a payment summary? |
Contributor: @ShridharGoel paid $250 via Upwork @ShridharGoel can you please accept the job and reply here once you have? |
$250 approved for @rushatgabhane |
@mallenexpensify @JmillsExpensify Accepted it |
@ShridharGoel paid, main payment post updated above Thx |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: Link
Action Performed:
Expected Result:
This is what the splash should look like:
Actual Result:
Workaround:
N/A
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
View all open jobs on GitHub
cc @grgia - we talked about this one in Slack, sorry for the delay in creating the issue. Any details you want to add?
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: