Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Paid] [$500] [Mentions v2] Update the SuggestionMention to show the auto-complete widget when trying to mention a room #39532

Closed
rlinoz opened this issue Apr 3, 2024 · 11 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering NewFeature Something to build that is a new item.

Comments

@rlinoz
Copy link
Contributor

rlinoz commented Apr 3, 2024

When trying to mention a room we want to display the auto-complete widget with the matching reports when the mention is happening in a report that belongs to a policy.

  • The room mention starts with #
  • The auto-complete widget will show only rooms that belong to the same policy that the mention is happening and that includes what is being typed
  • If a mention starts in a room that doesn't belong to a policy we won't show the auto-complete widget

Details can be found here in the Mentions V2 design doc.

Copy link

melvin-bot bot commented Apr 3, 2024

@melvin-bot melvin-bot bot added the Weekly KSv2 label Apr 3, 2024
Copy link

melvin-bot bot commented Apr 3, 2024

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

@robertKozik
Copy link
Contributor

Hi! Can you assign me to this issue?

@rlinoz
Copy link
Contributor Author

rlinoz commented Apr 4, 2024

@robertKozik do you have an ETA for this one?

@robertKozik
Copy link
Contributor

I think I'm half way done already. I think tomorrow I'll finish the implementation and prepare the PR

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Apr 5, 2024
@paultsimura
Copy link
Contributor

This was deployed to production, due payment [2024-04-29]

@rlinoz rlinoz added Awaiting Payment Auto-added when associated PR is deployed to production and removed Reviewing Has a PR in review labels Apr 22, 2024
@paultsimura
Copy link
Contributor

  • The PR that introduced the bug has been identified. Link to the PR: N/A – new feature
  • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
  • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
  • Determine if we should create a regression test for this bug: Yes
  • If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

  1. Create several rooms within one Workspace
  2. Open a room chat and start typing room mentions (room name with # prefix)
  3. Verify the room suggestions are displayed above the composer.
  4. Verify that every room inside the suggestions list is connected to the same policy as the opened room
  5. Open a 1:1 chat
  6. Start typing #...
  7. Verify that no auto-complete widget is present while typing a room mention

Do we agree 👍 or 👎

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Apr 29, 2024
@strepanier03 strepanier03 changed the title [Mentions v2] Update the SuggestionMention to show the auto-complete widget when trying to mention a room [Payment due 2024-04-29] [$500] [Mentions v2] Update the SuggestionMention to show the auto-complete widget when trying to mention a room Apr 30, 2024
Copy link

melvin-bot bot commented Apr 30, 2024

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

@strepanier03
Copy link
Contributor

Payment summary

@paultsimura
Copy link
Contributor

Accepted, thanks😌

@paultsimura
Copy link
Contributor

@strepanier03 bump on the payment, thanks

@strepanier03 strepanier03 changed the title [Payment due 2024-04-29] [$500] [Mentions v2] Update the SuggestionMention to show the auto-complete widget when trying to mention a room [Paid] [$500] [Mentions v2] Update the SuggestionMention to show the auto-complete widget when trying to mention a room May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering NewFeature Something to build that is a new item.
Projects
None yet
Development

No branches or pull requests

4 participants