Search - Searched results on the list are not filtered correctly

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.63-0
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR : #37909
Email or phone of affected tester (no customers): gocemate@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Open Search Page
2. Type something in the search input ( any user name and surname)
3. Check the search results

Expected Result:

Results on the list should be filtered to match the searched phase

Actual Result:

Searched results on the list are not filtered correctly
Announce room appear when search for the user name

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6453321_1713426626247.Recording__2842.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @MariaHCD (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@bfitzexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

Production

bandicam.2024-04-18.13-46-10-964.mp4

[MariaHCD]

I'm not sure this is a frontend issue. I wonder if it's something in the backend logic for report search that is resulting in the #announce room showing in the search results.

cc: @marcaaron @youssef-lr if you have any ideas here?

[thienlnam]

Seems to be expected from this discussion https://expensify.slack.com/archives/C01GTK53T8Q/p1713546999765829

We're guessing that there is either a chat or a member in that announce room. However, the odd thing is that this is not on production so we're unsure if this was an intended change or not

[MariaHCD]

@izarutskaya Would you be able to confirm if the user email you searched for is part of the #announce room that displays in the search results?

[MariaHCD]

Also, can we get the response from the SearchForReports command -

1. Pull up the Chrome Developer Tools press command + option + i and then select the Network tab.
2. Enter the search term in the search input
3. Click on SearchForReports in the console
4. Click on the Preview tab then expand onyxData > 1: {onyxMethod: "mergecollection", key: "report_", value: {,…}}
5. Right-click on value > Copy object and paste the results here

[bfitzexpensify]

Asked in #qa for an answer to #40424 (comment)

[izarutskaya]

@MariaHCD Yes, I can reproduce it if this user is part of the # announce room. Check my video please for gmail and Expensifail accounts

Recording.2394.mp4

Recording.2395.mp4

[MariaHCD]

Yes, I can reproduce it if this user is part of the # announce room

This is expected. If the user is part of the room, then searching for their email will include the #announce room in the results (relevant code here)

@izarutskaya can you reproduce the error is the user is not part of the #announce room?

[MariaHCD]

Not overdue, we just need to retest again if this behavior occurs when the user is not part of the #announce room

[bfitzexpensify]

Bumped the thread in Slack for Irina to confirm.

[izarutskaya]

@MariaHCD No, I cannot reproduce this issue if the user is not part of the #announce room

Recording.2413.mp4

[MariaHCD]

Thanks for confirming! Then I think this isn't a bug and we should be good to close this one out.