[HOLD for payment 2024-06-11] [$250] Taxes - App allows deleted tax rate to be selected as currency default in offline mode

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.66-1
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• Workspace and Foreign currency default share the same tax rate.
• There are Tax rate A and B.

1. Go to staging.new.expensify.com
2. Go to Account settings > Workspaces > any workspace.
3. Go to Taxes.
4. Go offline.
5. Delete one of the tax rate which is not the default tax rate.
6. Go to Settings > Workspace currency default.
7. Select the deleted tax rate.
8. Now delete the remaining tax rate.

Expected Result:

In Step 7, user should not be able to select the deleted tax rate.

Actual Result:

In Step 7, user is able to select the deleted tax rate, which results in all the tax rate being able to be deleted.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6462146_1714080991768.20240426_052954.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0120c22699693bf475
• Upwork Job ID: 1785526833780477952
• Last Price Increase: 2024-05-15
• Automatic offers:
• Krishna2323 | Contributor | 0

Issue Owner

Current Issue Owner: @JmillsExpensify

[izarutskaya]

We think this issue might be related to the #collect project.

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Taxes - App allows deleted tax rate to be selected as currency default in offline mode

What is the root cause of that problem?

We don't have any logic to exclude the deleted options or to disable the option when deleted offline.

What changes do you think we should make in order to solve the problem?

We can solve the issue in 2 ways.

1. Exclude the deleted option from the list.
   

   App/src/libs/OptionsListUtils.ts

   Line 1351 in 1e8053e

   const enabledTaxRates = sortedTaxRates.filter((taxRate) => !taxRate.isDisabled);

   
   Update to:

const enabledTaxRates = sortedTaxRates.filter((taxRate) => !taxRate.isDisabled && !(taxRate.pendingAction === 'delete'));

2. Return the pending action pendingAction: taxRate.pendingAction from getTaxRatesOptions. Then update the BaseListItem to use item.pendingAction as optional pendingAction value (pendingAction={pendingAction || item.pendingAction}). Also we need to update the disabled in BaseListItem to disable the option when pending action is delete (disabled={isDisabled || item.pendingAction===CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE}).

Note: There might be similar pages with similar functionality, we need to check for that also. Also, we might not need to make changes when pending action is update/add, that can be excluded.

What alternative solutions did you explore? (Optional)

We can directly disable the option in getTaxRatesOptions by updating the isDisabled property to isDisabled: taxRate.isDisabled || taxRate.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE.

1. We need to return pendingAction for options, from util functions like getCategoryListSections.
2. In getCategoryOptionTree we will set disabled as true if option.pendingAction === 'delete'.
3. In RadioListItem, we need to pass pendingAction={item.pendingAction} to BaseListItem.

Alternative solutions 2

• Return the pending action pendingAction: taxRate.pendingAction from getTaxRatesOptions.
• In renderItem function update the isDisabled value to also check for item.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE and pass the pending action pendingAction={item.pendingAction}.
• Accept pendingAction in RadioListItem and then pass it to BaseListItem.

[Krishna2323]

Proposal Updated

• Added note.

[melvin-bot]

@JmillsExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[JmillsExpensify]

Adding as polish for wave-collect and opening up to the community.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0120c22699693bf475

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[sobitneupane]

Thanks for the proposal @Krishna2323

I tested Categories and the issue is reproducible. I am pretty sure the issue lies in other similar functionality as well.

@JmillsExpensify Should we completely hide the deleted tax, or simply disable it in the list?

[melvin-bot]

@JmillsExpensify, @sobitneupane Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@JmillsExpensify, @sobitneupane Huh... This is 4 days overdue. Who can take care of this?

[sobitneupane]

@JmillsExpensify Any thoughts on #41066 (comment)?

[melvin-bot]

@JmillsExpensify @sobitneupane this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@JmillsExpensify, @sobitneupane Eep! 4 days overdue now. Issues have feelings too...

[JmillsExpensify]

Good question. I tend to think that we should hide it in those other lists shown in the OP, especially given that we already use the pending pattern where the actual deletion occurred. cc @trjExpensify in case you disagree.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.78-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Taxes - App allows deleted tax rate to be selected as currency default in offline mode. #42620

If no regressions arise, payment will be issued on 2024-06-11. 🎊

For reference, here are some details about the assignees on this issue:

• @sobitneupane requires payment through NewDot Manual Requests
• @Krishna2323 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
• [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@sobitneupane] Determine if we should create a regression test for this bug.
• [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

@JmillsExpensify, @Beamanator, @sobitneupane, @Krishna2323 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Krishna2323]

@JmillsExpensify, bump for payments.

[melvin-bot]

@JmillsExpensify, @Beamanator, @sobitneupane, @Krishna2323 Still overdue 6 days?! Let's take care of this!

[JmillsExpensify]

@sobitneupane mind filling out the BZ checklist? In the meantime, payment summary as follows:

• Contributor: $250 @Krishna2323
• Contributor+: $250 @sobitneupane

[JmillsExpensify]

Contributor paid out and C+ is paid through New Expensify, so I'm going to close this issue and we can circle back on checklist during payment approvals.

[sobitneupane]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:

The issue was already present in Section List. It was resurfaced in the app with the introduction of fields like Category, Tag and Tax fields

[sobitneupane]

Regression Test Proposal:

1. Go to Account settings > Workspaces > any workspace.
2. Go to Taxes.
3. Go offline.
4. Delete one of the tax rate which is not the default tax rate.
5. Go to Settings > Workspace currency default.
6. Verify deleted tax rate can't be selected and is styled correctly with strike-through

Do we agree 👍 or 👎

[JmillsExpensify]

Need someone else to confirm my payment summary. I've added the regression test in the meantime.

[mallenexpensify]

Contributor: $250 @Krishna2323 paid via Upwork
Contributor+: $250 @sobitneupane due via NewDot.

[JmillsExpensify]

$250 approved for @sobitneupane

[JmillsExpensify]

Everyone paid out and regression test created, so I'm closing this one.