-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for Payment [2024-05-15][$250] [Search v1] Resizing the screen to switch from the large screen to small screen breaks the back navigation on RHP. #41579
Comments
Job added to Upwork: https://www.upwork.com/jobs/~017875690bb8f76af2 |
Triggered auto assignment to @Christinadobrzyn ( |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.The not found page appear when clicking the back button What is the root cause of that problem?When you select a transaction detail on the search page, you're taken to the ReportScreen. On both the ReportScreen and the MoneyRequestHeader, which is responsible for displaying the header, clicking the back button triggers What changes do you think we should make in order to solve the problem?App/src/components/MoneyRequestHeader.tsx Line 191 in cca1952
If a transaction is opened on the search page (RHP), we should use the dismissModal function instead of the goBack function.
Optional: Additionally, for consistency, it's advisable to apply the same fix to ReportScreen Component, ensuring that the dismissModal function is used instead of the goBack function if this component is opened as RHP What alternative solutions did you explore? (Optional)Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job. |
@cretadn22 your solution looks hood. Maybe we can use a ternary though for simplicity and also apply the solution for the other headers in the RHP. |
📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @cretadn22 You have been assigned to this job! |
looks like PR is in the works! #41611 |
That PR has been merged. Just waiting on deploy. |
PR in production on May 9th payment due May 16th. |
Payouts due:
Upwork job is here. Do we need a regression test for this? |
No test needed, we'll add when we wrap up the project. |
Awesome, thanks @luacmartins. Paid this out based on this payment summary. Closing! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:
Action Performed
cc @adamgrzybowski @Kicu @WojtekBoman
Profile > Troubleshoot > New Search Page
/Search_Bottom_Tab
Expected Result:
Navigation should work
Actual Result:
Navigation is broken
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Screen.Recording.2024-05-03.at.8.26.47.AM.mov
Add any screenshot/video evidence
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @DylanDylannThe text was updated successfully, but these errors were encountered: