[HOLD for payment 2024-06-13] [$250] Search - Transaction report shows multiline title for expense with multiline description

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.70-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to FAB > Submit expense
3. Submit an expense containing multiline description and no merchant
4. Click on the search icon
5. If the transaction report does not show up in Search list, go to transaction thread and edit the description while maintaining multiline format

Expected Result:

The transaction report in search list will show single line title

Actual Result:

The transaction report in search list shows multiline title

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6470040_1714741364474.20240503_205118.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01765f6dc12ad2c849
• Upwork Job ID: 1793043171906035712
• Last Price Increase: 2024-05-21
• Automatic offers:
• DylanDylann | Reviewer | 102449287
• nkdengineer | Contributor | 102449290

Issue Owner

Current Issue Owner: @kevinksullivan

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@kevinksullivan FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The transaction report in search list shows multiline title

What is the root cause of that problem?

In HeaderView or LHN, we use DisplayNames component to show to report name and it used ReportUtils.formatReportLastMessageText function to replace all break line to space character.

App/src/components/DisplayNames/DisplayNamesWithTooltip.tsx

Line 59 in 2f5173c

? ReportUtils.formatReportLastMessageText(fullTitle)

But in UserListItem, we don't do this so the bug happens in the finder page.

App/src/components/SelectionList/UserListItem.tsx

Line 122 in 2f5173c

text={Str.removeSMSDomain(item.text ?? '')}

What changes do you think we should make in order to solve the problem?

We should do the same way as we do here to replace all line break when display the title of UserListItem

text={ReportUtils.formatReportLastMessageText(Str.removeSMSDomain(item.text ?? ''))}

App/src/components/SelectionList/UserListItem.tsx

Line 122 in 2f5173c

text={Str.removeSMSDomain(item.text ?? '')}

What alternative solutions did you explore? (Optional)

Or we can format formattedName in getReportName function to replace line break with space as we do here

App/src/libs/ReportUtils.ts

Line 3223 in e8ae3c5

return formattedName;

[melvin-bot]

@kevinksullivan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@kevinksullivan Eep! 4 days overdue now. Issues have feelings too...

[kevinksullivan]

Hm I am not experiencing this error @lanitochka17 . The search result shows as one line, even when I Am I misunderstanding?

[lanitochka17]

@kevinksullivan Need to create two transactions.

bandicam.2024-05-10.22-38-48-411.mp4

[melvin-bot]

@kevinksullivan Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@kevinksullivan Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@kevinksullivan Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@kevinksullivan Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@kevinksullivan this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@kevinksullivan 10 days overdue. Is anyone even seeing these? Hello?

[shawnborton]

Friendly bump on this one.

[kevinksullivan]

Thanks for clarifying @lanitochka17 . Can you update the original post with the correct steps? It didn't mention creating another transaction. I'll move this forward in the meantime!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01765f6dc12ad2c849

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

[DylanDylann]

Let's go with @nkdengineer's proposal

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @cristipaval, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[nkdengineer]

@DylanDylann this PR is ready for preview

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.79-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Transaction report shows multiline title for expense with multiline description #42631

If no regressions arise, payment will be issued on 2024-06-13. 🎊

For reference, here are some details about the assignees on this issue:

• @DylanDylann requires payment automatic offer (Reviewer)
• @nkdengineer requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@DylanDylann] The PR that introduced the bug has been identified. Link to the PR:
• [@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@DylanDylann] Determine if we should create a regression test for this bug.
• [@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[DylanDylann]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@DylanDylann] The PR that introduced the bug has been identified. Link to the PR: NA
[@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
[@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[@DylanDylann] Determine if we should create a regression test for this bug. No
[@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

I think this is minor, we don't need to create a regression test for this bug

Do we agree 👍 or 👎

[cristipaval]

This issue is on @kevinksullivan now.

[melvin-bot]

@cristipaval, @kevinksullivan, @DylanDylann, @nkdengineer Eep! 4 days overdue now. Issues have feelings too...

[kevinksullivan]

payments made!