[HOLD for payment 2024-06-11] [$250] Get Assistance workflow from bank account page doesn't match other workflows

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.70-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Go to https://staging.new.expensify.com/

2. Tap profile --- workspaces --- create a new workspace

3. Tap Profile > Tap more features

4. Enable Workflows

5. Tap Workflows -- tap connect bank account

6. Tap help question mark on top left

7. On the Get Assistance page, tap "chat with concierge" and tap device back button

8. Notice user is directed to workflow page

9. Tap explore help docs and tap device back button

10. Notice User correctly navigated back to "get assistance page"

Expected Result:

Expected Result: When tapping Back should navigate to Get assistance page for all the scenarios

• Tapping "Chat with Concierge" and pressing Back button redirects to "workflow page"
• Tapping "Schedule a setup call" and pressing Back button redirects to Get assistance page
• Tapping "Explore help docs" and pressing Back button redirects to Get assistance page

Actual Result:

From "chat with concierge" page when navigates back directed to Workflows page instead of Get assistance page.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6470289_1714756293396.yo.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0195f7d860bd49c0ee
• Upwork Job ID: 1789908451827134464
• Last Price Increase: 2024-05-20
• Automatic offers:
• eh2077 | Reviewer | 0
• nkdengineer | Contributor | 0

Issue Owner

Current Issue Owner: @Christinadobrzyn

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[kavimuru]

@twisterdotcom FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[twisterdotcom]

This was assigned after I finished work on Friday. I will be OOO all next week.

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• From "chat with concierge" page when navigates back directed to Workflows page instead of Get assistance page.

What is the root cause of that problem?

• In here:
  

  App/src/pages/GetAssistancePage.tsx

  Line 40 in 8383d80

  onPress: () => Report.navigateToConciergeChat(true),

  
  we use shouldDismissModal: true when navigating to concierge chat, leads to the Get assistance page is dissmissed, so when going back from concierge page, it redirects to Workflows page

What changes do you think we should make in order to solve the problem?

• We can call Report.navigateToConciergeChat(true) in case of desktop device (!DeviceCapabilities.canUseTouchScreen(): true). Otherwise, using Report.navigateToConciergeChat()

What alternative solutions did you explore? (Optional)

• NA

[melvin-bot]

@Christinadobrzyn Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Christinadobrzyn]

I think this might be part of guided setup - adding to wave-collect.

[Christinadobrzyn]

Sorry - I'm still trying to test this.. I think we want to update the "Get Assistance" page off the Bank setup

To match this "Get Assistance" page - but I can't figure out where this page exists... testing

[Christinadobrzyn]

Asking QA for a buddy check on the expected behaviour - https://expensify.slack.com/archives/C9YU7BX5M/p1715151549856419

[kavimuru]

The issue is about navigating back after clicking different options in Get assistance page.

• Tapping "Chat with Concierge" and pressing Back button redirects to "workflow page"
• Tapping "Schedule a setup call" and pressing Back button redirects to Get assistance page
• Tapping "Explore help docs" and pressing Back button redirects to Get assistance page

Expected Result: When tapping Back should navigate to Get assistance page for all the scenarios

[Christinadobrzyn]

Discussing with QA - https://expensify.slack.com/archives/C9YU7BX5M/p1715241694798869?thread_ts=1715151549.856419&cid=C9YU7BX5M

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[kavimuru]

Video added and OP updated. Hope it will help.

az_recorder_20240509_093653.1.mp4

[Christinadobrzyn]

Ah yes, that is helpful, I'll rewrite the OP steps based on this narrowed scope of the Android app.

[Christinadobrzyn]

Reached out to Rory to see if he can take a peek!

[melvin-bot]

📣 @eh2077 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[roryabraham]

looks good, but I agree with @eh2077 that we would dismiss the modal only on wide screens, as opposed to only on devices with touchscreens.

[nkdengineer]

@eh2077 this PR is ready for preview

[Christinadobrzyn]

monitoring PR - #42459

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.78-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: navigate back directed to Workflows page instead of Get assistance page #42459

If no regressions arise, payment will be issued on 2024-06-11. 🎊

For reference, here are some details about the assignees on this issue:

• @eh2077 requires payment automatic offer (Reviewer)
• @nkdengineer requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eh2077] The PR that introduced the bug has been identified. Link to the PR:
• [@eh2077] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eh2077] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@eh2077] Determine if we should create a regression test for this bug.
• [@eh2077] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Christinadobrzyn]

Payouts due:

• Contributor: $250 @nkdengineer (Upwork offer - https://www.upwork.com/nx/wm/offer/102682462)
• Contributor+: $250 @eh2077 (Upwork offer - https://www.upwork.com/nx/wm/offer/102682469)

Upwork job is here.

@eh2077 Do we need a regression test for this?

[eh2077]

Checklist

• [@eh2077] The PR that introduced the bug has been identified. Link to the PR: Fix composer won't focus after visiting concierge from get assistance page #40708
• [@eh2077] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/40708/files#r1634296913
• [@eh2077] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@eh2077] Determine if we should create a regression test for this bug. Yes, I think we can add a regression test for this because it's related to bank account page.

=== Mobile ===

1. Enable Workflows
2. Tap Workflows -- tap connect bank account
3. Tap help question mark on top left
4. On the Get Assistance page, tap "chat with concierge" and tap device back button
5. Verify that: user is directed to get assistance page

=== Web/Desktop ===

1. Enable Workflows
2. Tap Workflows -- tap connect bank account
3. Tap help question mark on top left
4. On the Get Assistance page, tap "chat with concierge"
5. Verify the composer is focused (only on web/desktop)

Do we agree 👍 or 👎

cc @Christinadobrzyn

[Christinadobrzyn]

LGTM! Regression test - https://github.com/Expensify/Expensify/issues/404152

@nkdengineer feel free to accept this offer and I'll pay you - https://www.upwork.com/nx/wm/offer/102682462

[nkdengineer]

@Christinadobrzyn Thanks a ton, accepted!

[Christinadobrzyn]

Paid you @nkdengineer based on our payment summary

Going to close this