-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-06-11] [$250] Get Assistance workflow from bank account page doesn't match other workflows #41610
Comments
Triggered auto assignment to @twisterdotcom ( |
@twisterdotcom FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors. |
This was assigned after I finished work on Friday. I will be OOO all next week. |
Triggered auto assignment to @Christinadobrzyn ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
What changes do you think we should make in order to solve the problem?
What alternative solutions did you explore? (Optional)
|
@Christinadobrzyn Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
I think this might be part of guided setup - adding to wave-collect. |
Asking QA for a buddy check on the expected behaviour - https://expensify.slack.com/archives/C9YU7BX5M/p1715151549856419 |
The issue is about navigating back after clicking different options in Get assistance page.
Expected Result: When tapping |
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989 |
Video added and OP updated. Hope it will help. az_recorder_20240509_093653.1.mp4 |
Ah yes, that is helpful, I'll rewrite the OP steps based on this narrowed scope of the Android app. |
Reached out to Rory to see if he can take a peek! |
📣 @eh2077 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
looks good, but I agree with @eh2077 that we would dismiss the modal only on wide screens, as opposed to only on devices with touchscreens. |
monitoring PR - #42459 |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.78-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-06-11. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Payouts due:
Upwork job is here. @eh2077 Do we need a regression test for this? |
Checklist
=== Mobile ===
=== Web/Desktop ===
Do we agree 👍 or 👎 |
LGTM! Regression test - https://github.com/Expensify/Expensify/issues/404152 @nkdengineer feel free to accept this offer and I'll pay you - https://www.upwork.com/nx/wm/offer/102682462 |
@Christinadobrzyn Thanks a ton, accepted! |
Paid you @nkdengineer based on our payment summary Going to close this |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.70-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:
Go to https://staging.new.expensify.com/
Tap profile --- workspaces --- create a new workspace
Tap Profile > Tap more features
Enable Workflows
Tap Workflows -- tap connect bank account
Tap help question mark on top left
On the Get Assistance page, tap "chat with concierge" and tap device back button
Notice user is directed to workflow page
Tap explore help docs and tap device back button
Notice User correctly navigated back to "get assistance page"
Expected Result:
Expected Result: When tapping Back should navigate to Get assistance page for all the scenarios
Actual Result:
From "chat with concierge" page when navigates back directed to Workflows page instead of Get assistance page.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6470289_1714756293396.yo.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @ChristinadobrzynThe text was updated successfully, but these errors were encountered: