Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-06-11] [Wave Collect] [Xero] Disable Taxes when connecting to QBO that doesn't enable Taxes by default #42466

Closed
lakchote opened this issue May 22, 2024 · 21 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@lakchote
Copy link
Contributor

We need to remove Taxes from the LHN when we're disconnecting from Xero and we had taxes sync enabled.

@lakchote lakchote self-assigned this May 22, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels May 22, 2024
@lakchote lakchote changed the title [Wave Collect] [Xero] Disable Taxes when disconnecting [Wave Collect] [Xero] Disable Taxes when connecting to QBO that doesn't support it May 22, 2024
@trjExpensify trjExpensify changed the title [Wave Collect] [Xero] Disable Taxes when connecting to QBO that doesn't support it [Wave Collect] [Xero] Disable Taxes when connecting to QBO that doesn't enable Taxes by default May 22, 2024
@mountiny mountiny removed the Reviewing Has a PR in review label Jun 4, 2024
@melvin-bot melvin-bot bot added the Overdue label Jun 4, 2024
@mountiny
Copy link
Contributor

mountiny commented Jun 4, 2024

@trjExpensify based on the comment this was not fully fixed, I think we need to find someone to look into this / retest and fix if its not done yet #42467 (comment)

@trjExpensify
Copy link
Contributor

Cool, I can retest after the next deploy.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jun 4, 2024
@melvin-bot melvin-bot bot changed the title [Wave Collect] [Xero] Disable Taxes when connecting to QBO that doesn't enable Taxes by default [HOLD for payment 2024-06-11] [Wave Collect] [Xero] Disable Taxes when connecting to QBO that doesn't enable Taxes by default Jun 4, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jun 4, 2024
Copy link

melvin-bot bot commented Jun 4, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.78-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-11. 🎊

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Jun 10, 2024
@trjExpensify
Copy link
Contributor

Can't repro this. Asking for a retest.

@trjExpensify trjExpensify added the retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause label Jun 11, 2024
Copy link

melvin-bot bot commented Jun 11, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

Copy link

melvin-bot bot commented Jun 13, 2024

@lakchote Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Jun 17, 2024

@lakchote 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@trjExpensify
Copy link
Contributor

Still waiting for a retest. CC: @mvtglobally @m-natarajan

Copy link

melvin-bot bot commented Jun 19, 2024

@lakchote 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

Copy link

melvin-bot bot commented Jun 21, 2024

@lakchote 10 days overdue. Is anyone even seeing these? Hello?

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jun 26, 2024
Copy link

melvin-bot bot commented Jun 26, 2024

This issue has not been updated in over 14 days. @lakchote eroding to Weekly issue.

@melvin-bot melvin-bot bot removed the Overdue label Jun 26, 2024
@lakchote
Copy link
Contributor Author

lakchote commented Jul 1, 2024

@mvtglobally @m-natarajan can you please retest as per @trjExpensify's comment above ?

@kbecciv
Copy link

kbecciv commented Jul 1, 2024

By following steps from #42466 (comment) - Taxes are enabled when connecting to QBO

2024-07-01.21-09-49.mp4

@lakchote
Copy link
Contributor Author

lakchote commented Jul 2, 2024

#42466 (comment)

I found the culprit, and pushed a PR to fix it here

cc @trjExpensify once you'll see why we weren't seeing the bug... ah 😄

@trjExpensify
Copy link
Contributor

Dang, nice sleuthing!

@mvtglobally mvtglobally removed the retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause label Jul 3, 2024
@mvtglobally
Copy link

Issue is reproducible during KI retests.

@lakchote
Copy link
Contributor Author

lakchote commented Jul 8, 2024

Fix disconnect QBO on native devices #44952

PR to fix this is up for review.

@allroundexperts
Copy link
Contributor

Comment for assignment

@bondydaa
Copy link
Contributor

bondydaa commented Jul 8, 2024

assigned @allroundexperts since they're helping to test the PR #44952

@trjExpensify
Copy link
Contributor

The regression period is over on this. Confirming payment summary as follows:

Go ahead and request! Closing.

@JmillsExpensify
Copy link

$250 approved for @allroundexperts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Reviewing Has a PR in review Weekly KSv2
Projects
No open projects
Archived in project
Development

No branches or pull requests

8 participants