[HOLD for payment 2024-10-24] [$250] mWeb/Safari - Chat - Keyboard does not close when action menu opens

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.85-6
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): gibethlehem+3gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to any chat
2. Click on the composer to bring the keyboard (if its not already open)
3. While the keyboard is open long press on a message to bring the action menu

Expected Result:

The keyboard closes when the action menu is opened

Actual Result:

The keyboard stays open when the action menu is opened

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6518642_1718815096023.Keyboard_Actionmenu.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0174c82b024da104ac
• Upwork Job ID: 1805674432646033914
• Last Price Increase: 2024-08-13
• Automatic offers:
• rojiphil | Reviewer | 103557667
• dominictb | Contributor | 103557669

Issue Owner

Current Issue Owner: @CortneyOfstad

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@CortneyOfstad FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[melvin-bot]

@CortneyOfstad Eep! 4 days overdue now. Issues have feelings too...

[CortneyOfstad]

Sorry, was OoO!

Was able to recreate, so going to get eyes on this!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0174c82b024da104ac

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There're 2 problems:

1. Keyboard does not close when users open popover from three dot

Screen.Recording.2024-06-26.at.17.39.26.mov

2. Keyboard does not close when users open action menu (the original issue)

What is the root cause of that problem?

1. We're getting the active input by this function

App/src/libs/ComposerFocusManager.ts

Lines 37 to 39 in 0c20881

	function getActiveInput() {
	return (TextInput.State.currentlyFocusedInput ? TextInput.State.currentlyFocusedInput() : TextInput.State.currentlyFocusedField()) as InputElement;
	}

but in web platform, we use the div with contentEditable to present the input

-> we can't get the active input -> the logic to blur input here is not triggered

2. To trigger blur input, we need to enable shouldEnableNewFocusManagement in

App/src/components/Modal/BaseModal.tsx

Lines 69 to 71 in 0c20881

	if (shouldEnableNewFocusManagement) {
	ComposerFocusManager.saveFocusState(uniqueModalId);
	}

but we did not enable it in PopoverWithMeasuredContent

What changes do you think we should make in order to solve the problem?

1. getActiveInput is implemented for both native and web platform, but it's not the same as this comment so we can separate this function in 2 file index.ts and index.native.ts

For native platform, we can keep using currentlyFocusedInput
For web/desktop platform, we can use document.activeElement

    const activeElement = document.activeElement
    if(activeElement?.getAttribute('contentEditable') || activeElement?.tagName === 'INPUT'){
        return activeElement
    }

2. Enable shouldEnableNewFocusManagement in PopoverWithMeasuredContent

What alternative solutions did you explore? (Optional)

Use ReportActionComposeFocusManager.composerRef.blur() in

App/src/pages/home/report/ReportActionItem.tsx

Line 346 in 5e65276

setIsContextMenuActive(true);

Result

Screen.Recording.2024-06-26.at.17.59.07.mov

[muttmuure]

This is not a #newdot-quality bug - the feature is not unreliable, slow or performing redundant or unexpected API calls, it just doesn't work as designed

[CortneyOfstad]

Thanks for the clarification @muttmuure!

[CortneyOfstad]

@rojiphil there is a proposal here for review 👍

[melvin-bot]

@rojiphil, @CortneyOfstad Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[CortneyOfstad]

@dominictb any update on the PR based on the last comment here?

[melvin-bot]

This issue has not been updated in over 15 days. @cead22, @rojiphil, @CortneyOfstad, @dominictb eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[dominictb]

@CortneyOfstad I have resolved the conflicts. Waiting for @rojiphil final review

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.49-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• feat: blur the composer focus when open context menu #47621

If no regressions arise, payment will be issued on 2024-10-24. 🎊

For reference, here are some details about the assignees on this issue:

• @rojiphil requires payment automatic offer (Reviewer)
• @dominictb requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rojiphil / @dominictb] The PR that introduced the bug has been identified. Link to the PR:
• [@rojiphil / @dominictb] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rojiphil / @dominictb] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rojiphil / @dominictb] Determine if we should create a regression test for this bug.
• [@rojiphil / @dominictb] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@CortneyOfstad] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[rojiphil]

• [@rojiphil] The PR that introduced the bug has been identified. Link to the PR: Offending PR
• [@rojiphil] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Added comment
• [@rojiphil] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not Required. Existing checklist is good enough to capture such issues.
• [@rojiphil] Determine if we should create a regression test for this bug. : Yes. We can
• [@rojiphil] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Steps:
Note: Tests are applicable only for native and mweb platforms.

1. Go to any chat
2. Click on the composer to bring the keyboard (if its not already open)
3. While the keyboard is open long press on a message to bring the action menu
4. Verify that the keyboard closes when the action menu is opened (Test 1)
5. Click and focus inside an editable message so that the keyboard is displayed.
6. While the keyboard is open long press on any other message to bring the action menu.
7. Verify that the keyboard closes when the action menu is opened (Test 2)

[rojiphil]

@CortneyOfstad BZ Checklist is done.

[cead22]

Waiting for payment - not overdue

[CortneyOfstad]

Sorry for the delay here!

@rojiphil – it looks like your offer expired back in September, so I issued you a new one here. Please let me know once you accept and I can get that paid ASAP. Thank you so much!

[rojiphil]

It looks like your offer expired back in September, so I issued you a new one here.

@CortneyOfstad Accepted offer. Thanks.

[CortneyOfstad]

Payment Summary

@dominictb — paid $250 via Upwork
@rojiphil — paid $250 via Upwork

Regression Test

https://github.com/Expensify/Expensify/issues/439515

[melvin-bot]

@cead22 @CortneyOfstad Be sure to fill out the Contact List!