Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] [$250 Reproduction Steps] There are chats in the LHN and could not be removed #44108

Closed
1 of 6 tasks
m-natarajan opened this issue Jun 20, 2024 · 33 comments
Closed
1 of 6 tasks
Assignees
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Needs Reproduction Reproducible steps needed

Comments

@m-natarajan
Copy link

m-natarajan commented Jun 20, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @danielvidal
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1718638249114319

Deliverable

The job is open to proposals. If someone is able to provide reliable reproduction steps, compensation will be $125.

Action Performed:

  1. Have a old workspace chat that are submitted and paid by the approver

Expected Result:

These very old expenses (archived chats)from months ago shouldn't appear in the LHN

Actual Result:

These very old expenses from months ago that re-appeared on the LHN out of nowhere

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

image (14)
image (15)

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019968f6b9ea37c469
  • Upwork Job ID: 1804224013010140122
  • Last Price Increase: 2024-07-12
@m-natarajan m-natarajan added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. AutoAssignerNewDotQuality Used to assign quality issues to engineers labels Jun 20, 2024
Copy link

melvin-bot bot commented Jun 20, 2024

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Jun 20, 2024

Triggered auto assignment to @techievivek (AutoAssignerNewDotQuality)

@melvin-bot melvin-bot bot added the Weekly KSv2 label Jun 20, 2024
@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@mallenexpensify mallenexpensify changed the title There are chats in the LHN and could not be removed [$125 Reproduction Steps] There are chats in the LHN and could not be removed Jun 21, 2024
@mallenexpensify mallenexpensify added the External Added to denote the issue can be worked on by a contributor label Jun 21, 2024
Copy link

melvin-bot bot commented Jun 21, 2024

Job added to Upwork: https://www.upwork.com/jobs/~019968f6b9ea37c469

@melvin-bot melvin-bot bot changed the title [$125 Reproduction Steps] There are chats in the LHN and could not be removed [$250] [$125 Reproduction Steps] There are chats in the LHN and could not be removed Jun 21, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 21, 2024
Copy link

melvin-bot bot commented Jun 21, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Jun 21, 2024
@mallenexpensify
Copy link
Contributor

Nipping this one in the bud a bit cuz I have a strong feeling it's going to be hard to reproduce. Added to OP

Deliverable

The job is open to proposals. If someone is able to provide reliable reproduction steps, compensation will be $125.

@kadiealexander
Copy link
Contributor

@quinthar also reported this happening here.

@melvin-bot melvin-bot bot added the Overdue label Jun 23, 2024
@srikarparsi
Copy link
Contributor

This also happens when a workspace member leaves a workspace. Their workspace chat becomes permanently unread. So:

  1. Account A: Create a workspace
  2. Account A: Add a member (Account B)
  3. Account B: Leave the workspace
  4. Account A: See that the Account B's workspace chat is permanently unread

But @kadiealexander reported that she didn't leave the workspace and instead BulkUnsharePolicies.php was used which causes sharePolicy. But I believe leavePolicy also eventually calls sharePolicy so there might be something related there? I don't think I'll be able to take over assignment @techievivek because I have a lot on my plate currently and I just got assigned a new NewDot reliability issue but I'll stay subscribed so that I might be able to help out since I've been doing some work with deletePolicy which is kind of related with archived reports.

I'm also not sure why I'm able to reliably produce this when leaving a workspace but this only occurred for @kadiealexander's workspace chat and not the others that were removed using BulkUnsharePolicies.php. Also cc @MonilBhavsar and @marcaaron if you guys have any ideas.

Copy link

melvin-bot bot commented Jun 24, 2024

@danielrvidal, @mallenexpensify, @allroundexperts, @techievivek Whoops! This issue is 2 days overdue. Let's get this updated quick!

@techievivek
Copy link
Contributor

I will try to reproduce this based on Srikar's comment here #44108 (comment)

@techievivek
Copy link
Contributor

Not overdue, still needs to reproduce this before we can move forward.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jun 25, 2024
Copy link

melvin-bot bot commented Jun 28, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Jun 28, 2024

@danielrvidal, @mallenexpensify, @allroundexperts, @techievivek Whoops! This issue is 2 days overdue. Let's get this updated quick!

@danielrvidal
Copy link
Contributor

This is still in my account so let me know if anyone needs to hop on a screen share with me to help diagnose. I've also logged in and out since reporting it so it seems persistent.

@muttmuure
Copy link
Contributor

Main tracking issue here: #44683

Copy link

melvin-bot bot commented Jul 2, 2024

@danielrvidal, @mallenexpensify, @allroundexperts, @techievivek 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@techievivek
Copy link
Contributor

I was unable to reproduce this issue after several attempts. Let me ask Applause to try reproducing it based on the steps mentioned here: #44108 (comment).

@melvin-bot melvin-bot bot removed the Overdue label Jul 3, 2024
@techievivek
Copy link
Contributor

@kavimuru
Copy link

kavimuru commented Jul 4, 2024

Unable to reproduce

bandicam.2024-07-03.18-20-00-878.mp4

Copy link

melvin-bot bot commented Jul 4, 2024

@danielrvidal @mallenexpensify @allroundexperts @techievivek this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Copy link

melvin-bot bot commented Jul 5, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Jul 8, 2024
@techievivek
Copy link
Contributor

@danielrvidal @mallenexpensify I am unable to reproduce this on my end, and the QA team was also unsuccessful in reproducing the issue #44108 (comment). What is the best way to move forward here?

@melvin-bot melvin-bot bot removed the Overdue label Jul 8, 2024
@mallenexpensify mallenexpensify changed the title [$250] [$125 Reproduction Steps] There are chats in the LHN and could not be removed [$250] [$250 Reproduction Steps] There are chats in the LHN and could not be removed Jul 9, 2024
@mallenexpensify
Copy link
Contributor

Raised price for reproduction steps to $250 and posted in #expensify-open-source
https://expensify.slack.com/archives/C01GTK53T8Q/p1720484027137579

@srikarparsi
Copy link
Contributor

@hurali97 seemed to have reproduced it here. Do you think you could lay out the reproduction steps? I think @techievivek can also assign you to this issue if you want to work on this.

@techievivek
Copy link
Contributor

Yeah, I can work on it, just waiting for clear reproduction steps.

@muttmuure
Copy link
Contributor

Asked Ali to take a look from CS. It's possible that this is a dupe

@hurali97
Copy link
Contributor

@srikarparsi We have a PR out here which fixes the issue where user was unable to mark a chat as read.

I just have one question, reading through the conversation it looks like there are two separate issues:

  • Can't mark archived chats as read
  • Some chats shouldn't appear in LHN but they are appearing anyway

The linked PR fixes only the first issue but not the second one as it is addressing this issue specifically.

Let us know if we are on the same page here. If we are, then @rinej maybe able to work on the second issue from Monday.

@muttmuure
Copy link
Contributor

@techievivek I think the question is for you too

Copy link

melvin-bot bot commented Jul 12, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Jul 12, 2024
@techievivek
Copy link
Contributor

@hurali97

Some chats shouldn't appear in LHN but they are appearing anyway

The second point you've listed is the problem here. There are some chats that appeared unexpectedly. Srikar provided these steps to reproduce the bug, but I wasn't able to reproduce the issue following those steps.

@melvin-bot melvin-bot bot removed the Overdue label Jul 15, 2024
@mallenexpensify
Copy link
Contributor

Went down a 🐰🕳 trying to test (and cleaning up LHN in my test account) and wasn't able to reproduce.

@danielrvidal
Copy link
Contributor

I still have the chat with Kadie in my LHN if it helps. Let me know if anyone wants me to do anything to diagnose.
image

Here is my Onyx State.
onyx-state.txt

@puneetlath
Copy link
Contributor

I think this is a dupe of #44693 so I'm going to close this. But please reopen if I'm mistaken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Needs Reproduction Reproducible steps needed
Projects
Development

No branches or pull requests