-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] mWeb - Get started - In mute mode, if enabled the video to full screen, unable to unmute video #45277
Comments
Triggered auto assignment to @mallenexpensify ( |
@mallenexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
We think that this bug might be related to #vip-vsp |
ProposalPlease re-state the problem that we are trying to solve in this issue.In mute mode, if enabled the video to full screen, unable to unmute video What is the root cause of that problem?
on mute, we set volume to 0, and isMuted is true here
When we entered fullscreen mute/unmute action only change the since the volume is 0, when we unmute on fullscreen, the volume still 0 so the icon still marked as muted What changes do you think we should make in order to solve the problem?Only set the
RESULT -1-New-Expensify.5.mp4What alternative solutions did you explore? (Optional) |
ProposalPlease re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
What changes do you think we should make in order to solve the problem?
to
with:
What alternative solutions did you explore? (Optional) |
Can't get browserstack to play audio, so everything is muted, trying to find a volunteer to snag |
@mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
No takers the first time, trying again. Added to VIP VSB project |
@mallenexpensify Huh... This is 4 days overdue. Who can take care of this? |
@strepanier03 , you're Android, right? If so, can I swap you this issue for any of yours? Thx |
Tested and was able to repro this @mallenexpensify. Using Android on Pixel 6 pro. Followed steps exactly and the behavior was 100% accurate. |
Job added to Upwork: https://www.upwork.com/jobs/~01eb6986a8fe073e62 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 ( |
@strepanier03 @eh2077 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
When the volume is 0 and the sound is muted, then click to unmute it, I like the new behaviour to automatically set volume to 0.25 as suggested by @dominictb. With this pre-condition
We have two options about the behaviour
Which one do you like? |
I think we should go with @dominictb 's proposal. I agree with their RCA and their suggestion to automatically set the volume to 0.25 as mentioned above. 🎀👀🎀 C+ reviewed |
Hmm I'm not too sure, do we have a rough idea of what is common practice with other apps? I think I lean towards option 1 though, given that when you unmute something, that means there should be at least some sound playing? |
@shawnborton You can try Youtube, its behavior is the same as our option 1 |
Cool, I can get down with Option 1 then. Let's see if @dubielzyk-expensify agrees though too. |
Yeah, option 1 sounds good to me as well then. |
📣 @eh2077 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
This issue has not been updated in over 15 days. @strepanier03, @cristipaval, @eh2077, @dominictb eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
This has been deployed to production two weeks ago. @strepanier03, did you handle the payments? (somehow the automation did not work) |
Contributor: @dominictb paid $250 via Upwork Sorry for the delay, the deploy we had a while back that didn't update issue nor remove @eh2077 plz complete the BZ checklist. BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Checklist
Regression test
Do we agree 👍 or 👎 |
Test case created, thx all! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.6
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
In mute mode, if enabled the video to full screen, must be able to unmute video
Actual Result:
In mute mode, if enabled the video to full screen, unable to unmute video
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6538246_1720637118840.Screenrecorder-2024-07-11-00-06-06-749_compress_1.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @eh2077The text was updated successfully, but these errors were encountered: