-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Awaiting checklist] [$250] mWeb - Chat - Keyboard is not dismissed when pasting an image on compose box #45471
Comments
Triggered auto assignment to @twisterdotcom ( |
@twisterdotcom FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
We think that this bug might be related to #vip-vsp |
ProposalPlease re-state the problem that we are trying to solve in this issue.mWeb - Chat - Keyboard is not dismissed when pasting an image on compose box What is the root cause of that problem?We do not blur the input before we call What changes do you think we should make in order to solve the problem?App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx Line 783 in 1465a92
onPasteFile={(file) => {
if (isKeyboardShown) {
textInputRef.current?.blur();
}
displayFileInModal(file);
}} We should also check if the keyboard is already shown or not. What alternative solutions did you explore? (Optional)We can blur the input in
|
ProposalPlease re-state the problem that we are trying to solve in this issue.Keyboard is not dismissed when pasting an image on compose box What is the root cause of that problem?chat composer is still focused and not blured when pasting the file content What changes do you think we should make in order to solve the problem?in the handlePaste function inside the composer we should blur the composer focus if the content is an attachment: App/src/components/Composer/index.tsx Lines 191 to 212 in 5a2602c
to do that we should add: textInput.current?.blur(); OR we can declare a helper function inside the |
Proposal Updated
|
Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane ( |
Job added to Upwork: https://www.upwork.com/jobs/~015f768185460c027a |
Current assignee @sobitneupane is eligible for the External assigner, not assigning anyone new. |
Thanks for the proposal everyone. Proposal from @Krishna2323 looks good to me. 🎀 👀 🎀 C+ reviewed |
Triggered auto assignment to @arosiclair, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
@sobitneupane, PR ready for review ^ |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.13-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-08-05. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Payment Summary:
|
@arosiclair, @twisterdotcom, @sobitneupane, @Krishna2323 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Bump on this @sobitneupane. |
Regression Test Proposal
Do we agree 👍 or 👎 |
I could not identify the exact PR which might have caused this issue. The feature was added by this PR. |
$250 approved for @sobitneupane based on this summary. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.7-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4724379
Email or phone of affected tester (no customers): vdargentotest+mweb071524@gmail.com
Issue reported by: Applause - Internal Team
Action Performed:
Pre-requisite: copy an image from the phone gallery
Expected Result:
The image preview page should be completely displayed
Actual Result:
The image preview page is partially displayed and the keyboard is not dismissed
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6543394_1721092979736.Smge1802_1_.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @sobitneupaneThe text was updated successfully, but these errors were encountered: