-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-08-19] [$250] Search - Select mode remains with empty state screen after deleting all expenses #46374
Comments
Triggered auto assignment to @sakluger ( |
We think that this bug might be related to #wave-collect - Release 1 |
@sakluger FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
ProposalPlease re-state the problem that we are trying to solve in this issue.Select mode remains with empty state screen after deleting all expenses What is the root cause of that problem?We don't set App/src/components/Search/index.tsx Lines 122 to 132 in 08bb00b
What changes do you think we should make in order to solve the problem?set
RESULT -1-New-Expensify.11.mp4What alternative solutions did you explore? (Optional) |
ProposalPlease re-state the problem that we are trying to solve in this issue.Select mode remains with empty state screen after deleting all expenses What is the root cause of that problem?When all expenses are deleted, isMobileSelectionModeActive remain true, causing the "selectMultiple" title to still be shown App/src/pages/Search/SearchPageBottomTab.tsx Lines 53 to 66 in 08bb00b
What changes do you think we should make in order to solve the problem?This is the logic for showing an empty view modal App/src/components/Search/index.tsx Lines 122 to 132 in 08bb00b
If
Removing the redundant SearchPageHeader component is important because it enhances performance (especially on mobile) and reduces errors in the logs What alternative solutions did you explore? (Optional) |
ProposalPlease re-state the problem that we are trying to solve in this issue.The select mode remains with empty state screen What is the root cause of that problem?When deleting any expenses, we don't set App/src/components/Search/SearchPageHeader.tsx Lines 149 to 156 in 98d8a5a
like we did in Hold and Unhold option:
What changes do you think we should make in order to solve the problem?We should use
when deleting selected expenses as well. What alternative solutions did you explore? (Optional)We can use
in this page. It will call |
Job added to Upwork: https://www.upwork.com/jobs/~01cece455709af5d24 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 ( |
Thanks for the proposals everyone!
|
Triggered auto assignment to @NikkiWines, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
Sorry for the notification, found a bug while testing selected proposal, I withdraw my previous decision. |
Proposal updatedUpdated the code changes in the alternative solution |
@hungvu193 I have updated the code changes in my alternative solution to make it easier for you to test. The general idea remains the same. |
I was about to ask you for more information. Thanks, will test it shortly
|
All good. Let's go with @dominictb 's alternative proposal. cc @NikkiWines |
@hungvu193 @dominictb I discover an improvement point. Let's include it in the PR phase |
@hungvu193 - does @cretadn22's comment impact your recommendation? |
No. I'll still keep my decision. Please assign @dominictb @NikkiWines |
Yep @dominictb's alt proposal looks good 👍 |
📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.18-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-08-19. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
This is a new feature that we added recently and still under development I believe so I don't think we need regression test for this one. |
Thanks @hungvu193. Could you please write out the proposed regression test steps? |
Summarizing payment on this issue: Contributor: @dominictb $250, paid via Upwork |
My bad, I updated the checklist |
Ah, that makes more sense. Thanks! |
$250 approved for @hungvu193 |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.13-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
Precondition:
Expected Result:
The select mode will exit because there is no more expense
Actual Result:
The select mode remains with empty state screen
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6554769_1722093464748.Screen_Recording_20240727_231204_New_Expensify.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @saklugerThe text was updated successfully, but these errors were encountered: