[HOLD for payment 2024-08-19] Expensify Card empty state list cuts off centered modal

[shawnborton]

When your screen is at a shorter size, the centered modal portion of the empty state list is cut off:

CleanShot.2024-08-01.at.05.59.03.mp4

cc @filip-solecki as we discussed in Slack

Issue Owner

Current Issue Owner: @isabelastisser

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[shawnborton]

@isabelastisser we're going to have @filip-solecki from SWM take this one.

[filip-solecki]

PR is ready for review! @shawnborton

[melvin-bot]

Triggered auto assignment to @francoisl, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.18-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix Expensify Card empty state list cuts off centered modal  #46649

If no regressions arise, payment will be issued on 2024-08-19. 🎊

For reference, here are some details about the assignees on this issue:

• @filip-solecki does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@francoisl] The PR that introduced the bug has been identified. Link to the PR: N/A, new feature
• [@francoisl] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@francoisl] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@filip-solecki] Determine if we should create a regression test for this bug. No
• [@filip-solecki] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[isabelastisser]

If all contributors are agency contributors and/or not paid via NewDot or Upwork, no payment summary post is necessary.

[isabelastisser]

@francoisl, do we need a regression test?

[francoisl]

I would say no, this was more of a style improvement for a relatively new feature.

[isabelastisser]

Thanks, Franc! Closing this.

[ikevin127]

@isabelastisser I just checked Upwork and looks like I wasn't paid for reviewing the PR for this issue.

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

This ^ #46648 (comment) seems to be incorrect.

[isabelastisser]

Hi @ikevin127, I apologize for the oversight! Thanks for linking the review here. I will process the payment in Upwork now.

[ikevin127]

@isabelastisser No worries, I accepted the offer. Thank you!