-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-08-19] Expensify Card empty state list cuts off centered modal #46648
Comments
Triggered auto assignment to @isabelastisser ( |
@isabelastisser we're going to have @filip-solecki from SWM take this one. |
PR is ready for review! @shawnborton |
Triggered auto assignment to @francoisl, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.18-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-08-19. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO. |
|
@francoisl, do we need a regression test? |
I would say no, this was more of a style improvement for a relatively new feature. |
Thanks, Franc! Closing this. |
@isabelastisser I just checked Upwork and looks like I wasn't paid for reviewing the PR for this issue.
This ^ #46648 (comment) seems to be incorrect. |
Hi @ikevin127, I apologize for the oversight! Thanks for linking the review here. I will process the payment in Upwork now. |
@isabelastisser No worries, I accepted the offer. Thank you! |
When your screen is at a shorter size, the centered modal portion of the empty state list is cut off:
CleanShot.2024-08-01.at.05.59.03.mp4
cc @filip-solecki as we discussed in Slack
Issue Owner
Current Issue Owner: @isabelastisserThe text was updated successfully, but these errors were encountered: