-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$125] Web - Search - Filters - Extra margin below Save button in Category filter #47046
Comments
Triggered auto assignment to @cristipaval ( |
Triggered auto assignment to @isabelastisser ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
We think that this bug might be related to #wave-collect - Release 1 |
ProposalPlease re-state the problem that we are trying to solve in this issue.Web - Search - Filters - Extra margin below Save button in Category filter What is the root cause of that problem?Extra padding bottom is applied. When we pass footer component them it is wrapped with
What changes do you think we should make in order to solve the problem?Remove We should also remove
What alternative solutions did you explore? (Optional)We can use the confirm button in App/src/components/SelectionList/BaseSelectionList.tsx Lines 726 to 738 in 53eee53
We need to pass the following props: showConfirmButton
confirmButtonText={translate('common.save')}
onConfirm={handleConfirmSelection} |
Definitely a NAB. Demoting. |
I'm also making it a $125 issue given the low complexity of the issue. |
Job added to Upwork: https://www.upwork.com/jobs/~012f06d1723cda4320 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts ( |
Upwork job price has been updated to $125 |
ProposalPlease re-state the problem that we are trying to solve in this issue.There is extra margin below the Save button. What is the root cause of that problem?We add
What changes do you think we should make in order to solve the problem?We can get:
and use it instead of |
ProposalPlease re-state the problem that we are trying to solve in this issue.Web - Search - Filters - Extra margin below Save button in Category filter There is one more bug on same page - Save button doesn't have top padding while we give padding on other pages. What is the root cause of that problem?For original issue - Extra bottom padding
For issue related to top padding -> App/src/pages/Search/SearchFiltersCategoryPage.tsx Lines 114 to 120 in cc4626f
What changes do you think we should make in order to solve the problem?
We can change For adding top padding - What alternative solutions did you explore? (Optional) |
ProposalBy change padding bottom of this div and make it 0px (the parent div that contains save button and categories names):Add padding top by 20px for this div (the parent div of the parent div of the save button):This is the result:Contributor details |
📣 @Mohammed-Ehap-Ali-Zean-Al-Abdin! 📣
|
Hey @allroundexperts, can you please review the proposals above? Thanks! |
Thanks for the proposals everyone. I think @dominictb's proposal has the correct RCA and the fix makes sense as well. Let's go with them. @BhuvaneshPatil You're trying to solve another bug here which isn't related to this issue. However, given the simplicity of this, I think we can merge the both into a single bug and pay $125 each to @BhuvaneshPatil and @dominictb. @cristipaval Let me know what you think. 🎀 👀 🎀 C+ reviewed |
Current assignee @cristipaval is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new. |
@allroundexperts, what do you think about my alternative solution? App/src/components/FixedFooter.tsx Lines 16 to 27 in 5dd0d8b
App/src/pages/Search/SearchFiltersCategoryPage.tsx Lines 112 to 123 in 53eee53
|
@Krishna2323 I'd much rather go with a more simpler solution 😄 |
@allroundexperts, I believe we can simply remove the padding top because the
App/src/components/FixedFooter.tsx Lines 16 to 27 in 5dd0d8b
|
@allroundexperts, the padding bottom is already covered in
|
📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
@cristipaval @allroundexperts Quick Nudge on this comment - #47046 (comment) |
@allroundexperts @cristipaval do we want to cover top padding in this issue as well? |
bump @allroundexperts on the question above. Thanks! |
@isabelastisser This is more of a question for you / @cristipaval. |
@BhuvaneshPatil In my opinion, we should fix that, too. @cristipaval, do you agree? Thanks! |
@allroundexperts, Cristi is on leave. Let's go ahead and fix this, thanks! |
@allroundexperts Do you want me to raise the PR or current assigned contributor will do that? If the automation and all allows, I am happy to raise the PR. |
@BhuvaneshPatil You can do that since you were the reporter 😄 |
@isabelastisser I don't believe we should expand the scope of this issue. The main objective is to fix 'There is extra margin below the Save button,' which is why the issue is priced at just $125. If we want to fix the additional bug you mentioned, we should create a separate issue so other contributors can focus on providing a suitable solution. |
@allroundexperts, how can we move this issue forward? |
@isabelastisser It's better to create a new issue. Can you please create one and assign me and @BhuvaneshPatil? Thanks! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.18-1
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Action Performed:
Expected Result:
There will be no extra margin below the Save button (production behavior).
Actual Result:
There is extra margin below the Save button.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6565196_1723085486947.20240808_104712.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @allroundexpertsThe text was updated successfully, but these errors were encountered: