-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] Search filters - Scrolling behavior after selecting currency and category is different #47058
Comments
Triggered auto assignment to @RachCHopkins ( |
Triggered auto assignment to @carlosmiceli ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
We think this issue might be related to the #collect project. |
Job added to Upwork: https://www.upwork.com/jobs/~01f10b9412daa7bb88 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 ( |
Edited by proposal-police: This proposal was edited at 2024-08-08 16:58:59 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.On Android and iOS, On web, mweb and desktop app, What is the root cause of that problem?We only do the scroll-with-animation after an option is selected, if the selection list has more than 1 section
However, the currency list in the search filter is different from other single-section list, we actually do sort the selected items on top
What changes do you think we should make in order to solve the problem?We need to make sure the currency list which has So we can update this block to
We can apply other sorting criteria to What alternative solutions did you explore? (Optional) |
Proposal updated to add an enhancement |
@dominictb What about |
On web, why |
@dukenv0307 Thanks for the feedback. I've updated the proposal, let me know if anything is still unclear. It works now for all platforms. |
Thank you. Let's go with @dominictb's proposal, it looks good and tests well. 🎀👀🎀 C+ reviewed |
Current assignee @carlosmiceli is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new. |
📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
Has the automation failed again @carlosmiceli? Is this done and ready to be paid? |
Yeah, looks like it... PR is already in prod, so yeah, this should be done. |
Payment Summary:
Upwork job here |
Contributors have been paid, the contracts have been completed, and the Upwork post has been closed. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.18-1
Reproducible in staging?: Y
Reproducible in production?: N
Found when executing PR : #46566
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:
via deep link.
Expected Result:
The scrolling behavior in filters should be the same after selecting currency and category.
Actual Result:
On Android and iOS,
In Step 5, the list does not scroll up after selecting a currency.
In Step 8, the list scrolls up after selecting a category.
On web, mweb and desktop app,
In Step 5, the list scrolls up without animation after selecting a currency.
In Step 8, the list scrolls up with animation after selecting a category.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6565464_1723112060019.web.mp4
Bug6565464_1723112060032.iOS.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @dukenv0307The text was updated successfully, but these errors were encountered: