-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] Android - Chat - Spacing below emoji picker when opening emoji picker while keyboard is up #48100
Comments
Triggered auto assignment to @johncschuster ( |
Triggered auto assignment to @stitesExpensify ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
📣 @c0ffincolors! 📣
|
The above comment asking you to download a file is malware to steal your account; do not under any circumstances download or run it. The post needs to be removed. If you have attempted to run it please have your system cleaned and your account secured immediately. |
📣 @caineblood! 📣
|
Job added to Upwork: https://www.upwork.com/jobs/~01f2e4be2af4f4a7d5 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan ( |
Edited by proposal-police: This proposal was edited at 2024-09-03 10:12:54 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.Spacing below emoji picker when opening emoji picker while keyboard is up What is the root cause of that problem?In the code App/src/components/Modal/BaseModal.tsx Line 44 in 4fe86eb
the props statusBarTranslucent is default to true. However, react native modal is buggy to calculate the height of modal with statusBarTranslucent=true see the GH issue here: facebook/react-native#35804
What changes do you think we should make in order to solve the problem?In the
Just attached the screen record after this change: untitled.webmWhat alternative solutions did you explore? (Optional)NA |
@johncschuster, @stitesExpensify, @situchan Eep! 4 days overdue now. Issues have feelings too... |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@johncschuster, @stitesExpensify, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@stitesExpensify bump! What are your thoughts on the question above? |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@johncschuster, @stitesExpensify, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@stitesExpensify bump! We've got an outstanding question here. |
Apologies for the delay, let's do both. I will double the payout since it is more work |
Upwork job price has been updated to $500 |
@QichenZhu I see that your another upstream PR was merged quickly. Similarly can you please create new issue and PR in upstream? |
@situchan Yeah, I’d love to. But I’m working on another issue assigned to me at the moment. Could I be assigned to this one? I’ll schedule it for tomorrow or early next week. |
📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @QichenZhu 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
Aiming to raise an upstream issue today. |
I raised an upstream issue facebook/react-native#47140. The solution I suggested there is different from my proposed one here because it needs to work in Bridgeless mode as well
|
@situchan I expect the fix will take a while since it needs to cover many scenarios, but in our repo it’s easier because we don’t use those configurations. I suggest we go with a simple patch in our repo, and I'll keep an eye on the upstream issue in parallel. What do you think? |
@QichenZhu sure. Feel free to raise patch PR |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.25-3
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh05081@applause.expensifail.com
Issue reported by: Applause Internal Team
Action Performed:
Expected Result:
There will be no spacing below the emoji picker.
Actual Result:
There is spacing below the emoji picker when opening emoji picker while keyboard is up.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6584231_1724771172692.1000031620-2024-08-27_15_03_10.713.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: