-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[payment due 9/6][$250] Avatar - Unable to choose profile avatar from library #48242
Comments
Triggered auto assignment to @Christinadobrzyn ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.The option to select image doesn't show after selecting Upload photo What is the root cause of that problem?The profile page is wrapped with MenuItemGroup. App/src/pages/settings/Profile/ProfilePage.tsx Lines 147 to 158 in c867918
MenuItemGroup pass down a context of single execution and wait for navigate function. App/src/components/MenuItemGroup.tsx Lines 22 to 31 in c867918
When we press Upload photo, it will call single execution and wait for navigate. Single execution will set the App/src/components/MenuItem.tsx Lines 531 to 540 in c867918
which will disable the menu item. App/src/components/MenuItem.tsx Line 583 in c867918
It will be enabled back once the promise of the action passed to App/src/hooks/useSingleExecution/index.native.ts Lines 26 to 33 in c867918
In our case, the promise is the App/src/hooks/useWaitForNavigation.ts Lines 27 to 31 in c867918
and it will be resolved once the blur event is triggered. But since there is no navigation happening, the promise is never resolved. This issue happens after the copilot PR where we move the profile image to profile page. What changes do you think we should make in order to solve the problem?We can disable the single execution + wait for navigate thing for the profile image picker by wrapping it with another
App/src/pages/settings/Profile/ProfilePage.tsx Lines 157 to 158 in c867918
Or we can do it the hard way by accepting a new props to disable either single execution or wait for navigate or both. What alternative solutions did you explore? (Optional) |
Triggered auto assignment to @yuwenmemon ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Job added to Upwork: https://www.upwork.com/jobs/~01ca983c30cf1e2b4a |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 ( |
📣 @eh2077 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
PR is ready cc: @eh2077 |
Since I reviewed the PR, can I be assigned here? |
Triggered auto assignment to @zanyrenney ( |
Looks like PR was deployed to production on 8/30. Payment day is 9/6. I'm going to be ooo so going to add a BZ teammate to issue payment. Payouts due:
cc @zanyrenney |
Yes, I'll request in ND. |
I don't think we need a regression test for this. |
Payment summary above closing as both are paid via ND. |
Requested in ND. |
$250 approved for @bernhardoj |
$250 approved for @allroundexperts |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.26-1
Reproducible in staging?: Y
Reproducible in production?: N
Pending when validation PR #47338
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:
Expected Result:
User should be able to choose profile avatar from library.
Actual Result:
Nothing happens after tapping Choose from library.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6585847_1724882763812.ScreenRecording_08-29-2024_06-02-18_1.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @eh2077The text was updated successfully, but these errors were encountered: