[Payment due October 4]Remove any code that references or was used only for free workspaces (policies)

[tgolen]

Problem

There was a project this summer to deprecate and remove all of the free workspaces in Expensiy and migrate them over to team workspaces. Now that there are no free workspaces in the database or in the backend, there is a lot of leftover code that is no longer necessary.

Why is this important to solve?

Keeping the code up-to-date reduces technical debt and allows it to be more easily maintained.

Solution

Find any code that references or was used only for the free plan in E/App and remove it.

Issue Owner

Current Issue Owner: @situchan

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[cretadn22]

@tgolen
Should we also remove the Personal Policy?

[cretadn22]

Edited by proposal-police: This proposal was edited at 2024-08-30 17:00:38 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove any code that references or was used only for free workspaces

What is the root cause of that problem?

New refactor

What changes do you think we should make in order to solve the problem?

Remove CONST.POLICY.TYPE.FREE and PolicyUtils.isFreeGroupPolicy, and clean up all instances where they are used.

Also, remove the corresponding routes and pages associated with them

• ROUTES.WORKSPACE_CARD
• ROUTES.WORKSPACE_REIMBURSE
• ROUTES.WORKSPACE_BILLS

Remove: workspace.type.free translation

What alternative solutions did you explore? (Optional)

[tgolen]

Should we also remove the Personal Policy?

Nope, that one needs to stay there.

While you are looking for the code that can be removed, I've heard reports that there are pages or routes that are still referencing the free plan somehow, so please try to track down any pages or URL routes of that nature too. They might not be referencing that constant, so they might be a little tricky to find.

[cretadn22]

Proposal updated

[cretadn22]

@tgolen Could you review it once more?

[melvin-bot]

@tgolen, @Christinadobrzyn, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Christinadobrzyn]

Just a heads up - I'm going to be ooo 9/4-9/10. I'll add a BZ teammate to watch this while I'm away!

@anmurali - we are reviewing/discussing this proposal. So I think you'll just need to monitor this but I don't expect anything will be needed while I'm away.

[tgolen]

bump @situchan Can you please give the proposals a look?

[situchan]

We can go with @cretadn22's proposal.
Please add screenshots of all pages to be removed from route in PR. (opened from deep link)
🎀👀🎀 C+ reviewed

[melvin-bot]

Current assignee @tgolen is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[Christinadobrzyn]

@tgolen, when you have a moment, can you please check out this proposal review? TY! #48345 (comment)

[tgolen]

@Christinadobrzyn Yeah, I had a look at it and assigned them a couple of weeks ago. It looks like they have a PR that is ready for review which I'm going to be taking a look at today.

[Christinadobrzyn]

Thanks for the update @tgolen!

It looks like this PR was just merged to staging.

heads up - I'm going to be ooo until 9/30. Since we're reviewing PRs I'm not going to assign a BZ teammate to monitor this while I'm gone. If you need someone while I'm gone please feel free to reach out in Slack for a volunteer. TY!

[Christinadobrzyn]

PR in production! Adding payment date to the title.

Payouts due:

• Contributor: $250 @cretadn22 (Paid in Upwork - https://www.upwork.com/nx/wm/offer/104189664)
• Contributor+: $250 @situchan (Upwork offer - https://www.upwork.com/nx/wm/offer/104260166)

Do we need a regression test (I assume not?)

[situchan]

No need regression test. I am paid via upwork

[Christinadobrzyn]

Thanks @situchan can you accept this offer - #48345 (comment)

TY!

[Christinadobrzyn]

Moving to daily to pay this out.

[Christinadobrzyn]

waiting on @situchan to accept the offer - https://www.upwork.com/nx/wm/offer/104260166

[Christinadobrzyn]

This is paid out! Based on this payment summary #48345 (comment)

Closing as complete