[$250] Web - Sage - Two console errors appear when downloading the Expensify package for Sage Intacct

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.34-3
Reproducible in staging?: Y
Reproducible in production?: Y
Issue reported by: Applause Internal Team

Action Performed:

1. Navigate to https://staging.new.expensify.com/
2. Log in with a new Gmail account
3. Click on FAB - New workspace
4. Enable "Accounting" in the "More features" page.
5. Navigate to "Accounting"
6. Click on "Sage Intacct" and upgrade the workspace to Control when asked
7. Click on the "Got it, thanks" button
8. Click on "Download the Expensify package for Sage Intacct"
9. Click on "Save" or "Cancel"

Expected Result:

There shouldn't be any console errors.

Actual Result:

Two console errors appear when downloading the Expensify package for Sage Intacct.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1609_1.txt

Bug6602779_1726254297428.bandicam_2024-09-13_20-54-01-852.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021835811720150989795
• Upwork Job ID: 1835811720150989795
• Last Price Increase: 2024-09-23
• Automatic offers:
• shubham1206agra | Reviewer | 104115002
• Krishna2323 | Contributor | 104115003

Issue Owner

Current Issue Owner: @shubham1206agra

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #wave-control

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021835811720150989795

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[Krishna2323]

Proposal


Please re-state the problem that we are trying to solve in this issue.

Web - Sage - Two console errors appear when downloading the Expensify package for Sage Intacct.

What is the root cause of that problem?

Due to CORS policy the error is shown when we try to fetch the file using url.

App/src/pages/workspace/accounting/intacct/SageIntacctPrerequisitesPage.tsx

Line 43 in 3b850e8

fileDownload(CONST.EXPENSIFY_PACKAGE_FOR_SAGE_INTACCT, CONST.EXPENSIFY_PACKAGE_FOR_SAGE_INTACCT_FILE_NAME);

What changes do you think we should make in order to solve the problem?


We should pass shouldOpenExternalLink as true when using fileDownload in SageIntacctPrerequisitesPage.

fileDownload(CONST.EXPENSIFY_PACKAGE_FOR_SAGE_INTACCT, CONST.EXPENSIFY_PACKAGE_FOR_SAGE_INTACCT_FILE_NAME, '', true);

• We should also check similar components which used fileDownload to download files like these.

What alternative solutions did you explore? (Optional)

Result

[melvin-bot]

@lschurr, @shubham1206agra Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[lschurr]

@shubham1206agra please review the proposal

[shubham1206agra]

@Krishna2323's proposal looks good.

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @stitesExpensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@lschurr, @stitesExpensify, @shubham1206agra Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Krishna2323]

@shubham1206agra, PR ready for review ^

[Krishna2323]

@lschurr, PR was deployed to production 2 weeks ago, this one is ready for payments.

[lschurr]

@shubham1206agra Can you accept the offer?

[lschurr]

Payment summary:

• Contributor: $250 @Krishna2323 (Paid in Upwork)
• Reviewer: $250 @shubham1206agra (Paid in Upwork)

[melvin-bot]

@lschurr @stitesExpensify @shubham1206agra @Krishna2323 this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[shubham1206agra]

@lschurr Offer accepted

[melvin-bot]

@lschurr, @stitesExpensify, @shubham1206agra, @Krishna2323 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[lschurr]

This is done!