[HOLD for payment 2024-10-11] [$250] iOS - Search - Sluggish animation when selecting a different type for the second time

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.35-0
Reproducible in staging?: Y
Reproducible in production?: Y
Issue was found when executing this PR: #49058
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Launch New Expensify app.
2. Go to Search.
3. Tap on the dropdown.
4. Tap Chats.
5. Open the dropdown.
6. Select Invoices.

Expected Result:

The animation should be smooth when selecting a different type.

Actual Result:

The animation is sluggish after selecting a different type for the second time.
Both "Expenses" and "Chats" are highlighted when selecting Invoices.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6603136_1726284959100.ScreenRecording_09-14-2024_11-30-11_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021836327300747021225
• Upwork Job ID: 1836327300747021225
• Last Price Increase: 2024-09-18
• Automatic offers:
• truph01 | Contributor | 104127739

Issue Owner

Current Issue Owner: @fedirjh

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@sonialiap FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[truph01]

Edited by proposal-police: This proposal was edited at 2023-10-12T10:00:00Z.

Proposal

Please re-state the problem that we are trying to solve in this issue.

• iOS - Search - Sluggish animation when selecting a different type for the second time

What is the root cause of that problem?

• When selecting any type, we call:
  

  App/src/pages/Search/SearchTypeMenuNarrow.tsx

  Line 58 in 14b99ca

  const closeMenu = useCallback(() => setIsPopoverVisible(false), []);

  
  first and then:
  

  App/src/pages/Search/SearchTypeMenuNarrow.tsx

  Lines 74 to 75 in 14b99ca

  	SearchActions.clearAllFilters();
  	Navigation.navigate(item.route);

• After the call closeModal, the modal is not hidden immediately, so we encountered the current behavior.

What changes do you think we should make in order to solve the problem?

• We should add shouldCallAfterModalHide: true:
  

  App/src/pages/Search/SearchTypeMenuNarrow.tsx

  Line 71 in 14b99ca

  return {

  
  and
  

  App/src/pages/Search/SearchTypeMenuNarrow.tsx

  Line 108 in 14b99ca

  const savedSearchItems = savedSearchesMenuItems.map((item) => ({

  
  to make sure the modal is closed successfully before running the remaining logic.

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021836327300747021225

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[fedirjh]

@truph01's proposal looks good to me.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @deetergp, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[truph01]

@deetergp Please help review my proposal since C+ has reviewed it. Thanks.

[melvin-bot]

@deetergp, @sonialiap, @fedirjh Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

📣 @truph01 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[truph01]

PR is ready

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.44-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Sluggish animation when selecting a different type #49736

If no regressions arise, payment will be issued on 2024-10-11. 🎊

For reference, here are some details about the assignees on this issue:

• @fedirjh requires payment through NewDot Manual Requests
• @truph01 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
• [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@fedirjh] Determine if we should create a regression test for this bug.
• [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sonialiap]

Payment summary:
@fedirjh $250 - please request in NewDot and complete the checklist 😁
@truph01 $250 - paid via upwork ✔️

[melvin-bot]

@deetergp, @sonialiap, @fedirjh, @truph01 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[fedirjh]

BugZero Checklist:

• Link to the PR: fix(PopoverMenu): fix opening external links #45762
• Link to comment: N/A Author is aware of the bug and has
• Link to discussion: N/A
• Determine if we should create a regression test for this bug: N/A , it's a simple UI improvement , doesn’t require regression test.

[garrettmknight]

$250 approved for @fedirjh