[HOLD for payment 2024-10-11] Onyx.connect for a collection is not fetching the full collection in some files in dev

[puneetlath]

We seem to have a dev-only issue with Onyx.connect and collections. Context here: https://expensify.slack.com/archives/C05LX9D6E07/p1726908940614449

Issue Owner

Current Issue Owner: @OfstadC

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[fabioh8010]

Hi, I'm Fábio from Callstack - expert agency - and I would like to work on this issue.

[fabioh8010]

PR is ready to review

[OfstadC]

Not overdue - PR was published. So I believe this is just awaiting payment?

[fabioh8010]

The Onyx Bump PR is ready to review -> #49857

[fabioh8010]

The Onyx Bump PR was merged 🚀

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[OfstadC]

I believe only @parasharrajat is due payment here. If i'm wrong, please let me know!

Payment Summary

• @parasharrajat due $250 via New Expensify request

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.44-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Bump Onyx to v2.0.71 #49857

If no regressions arise, payment will be issued on 2024-10-11. 🎊

For reference, here are some details about the assignees on this issue:

• @fabioh8010 does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [] The PR that introduced the bug has been identified. Link to the PR:
• [] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@fabioh8010] Determine if we should create a regression test for this bug.
• [@fabioh8010] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@OfstadC] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[OfstadC]

Ope - looks like I paid this early 😅

@fabioh8010 Could you complete the BugZero checklist? Thank you!

[OfstadC]

Going to close this as we've already issued payment, but if this requires regression testing, please let me know @fabioh8010 ! Thanks!~

[fabioh8010]

Hi @OfstadC , I'm from an expert agency, correct me if I'm wrong but it's not up to me to complete this checklist 😅

[parasharrajat]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: N/A
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@parasharrajat] Determine if we should create a regression test for this bug. N/A
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

[parasharrajat]

Payment requested as per #49609 (comment)

[JmillsExpensify]

$250 approved for @parasharrajat