-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-10-30] [HOLD for payment 2024-10-29] [3rd Party Feeds] Implement API calls for 3rd part workspace feeds v1 #49690
Comments
Auto-assigning issues to engineers is no longer supported. If you think this issue should receive engineering attention, please raise it in #whatsnext. |
Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue. |
WorkspaceCompanyCardsPage.tsx
WorkspaceCompanyCardsListHeaderButtons.tsx
WorkspaceCompanyCardsSettingsPage.tsxWorkspaceCompanyCardFeedSelectorPage.tsxWorkspaceMemberNewCardPage.tsx
CardSelectionStep.tsx
|
Hi, I'm Nicolay from Callstack - expert contributor group - will help here as well (from tomorrow).
|
Assigned! |
@robertjchen I have a question about reportActionID for this API call: Is it for this message? Should I optimistically create it? I'm asking cause it looks like we don't create similar messages optimistically while issuing Expensify Cards. |
Interesting! That's a good point- if these messages are not being optimistically created, then the |
@robertjchen I think it's a bit different thought, right? With Expensify cards, we have to talk to Marqeta, a third-party service, and so there is a higher chance of the call with fail, so we do not create the actions optimistically. In this case, when we already have the list of the available cards, there are fewer things that can cause it to fail, so I think we could consider adding these optimistically; what do you think, @robertjchen? |
That makes sense, that context definitely helps! Since we already have all the info we need in Onyx at time of assignment, we can definitely do it optimistically which would make for a better user experience |
@VickyStash Feel free to add the optimistic reportActionID param to the api call and create the action optimistically and we can add it to BE |
@robertjchen Could you say what action name this optimistic report action should have? I'm talking about the one created during AssignCard API call. |
@VickyStash It would be |
I've prepared a Draft PR with:
@robertjchen Please, let us know when RequestFeedSetup is deployed so we can start extensive testing of the functionality with the real data. |
Yes, it appears to be under review at the moment 👍 |
Making progress |
Updates:
|
Triggered auto assignment to @strepanier03 ( |
Reassigning as I head to parental leave next week! Thanks Sheena! |
♻️ PR was merged |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.51-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-10-29. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
No checklist here, this belongs to a project, Only payment remains 🙏 (This is a 3rd party feed project and not direct feed so...) |
$250 to @allgandalf |
🤣 i wonder what you are doing in 🇯🇵 these days |
psst |
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-10-30. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
No checklist, payment summary here |
New feature so no checklist needed here |
Coming from this thread, we have some clean up to-dos for the Third-party workspace feeds v1 initiative.
Issue Owner
Current Issue Owner: @strepanier03The text was updated successfully, but these errors were encountered: