[HOLD for payment 2024-10-30] [HOLD for payment 2024-10-29] [3rd Party Feeds] Implement API calls for 3rd part workspace feeds v1

[dylanexpensify]

Coming from this thread, we have some clean up to-dos for the Third-party workspace feeds v1 initiative.

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Auto-assigning issues to engineers is no longer supported. If you think this issue should receive engineering attention, please raise it in #whatsnext.

[VickyStash]

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

[robertjchen]

WorkspaceCompanyCardsPage.tsx

• OpenPolicyCompanyCardsPage(policyID)

WorkspaceCompanyCardsListHeaderButtons.tsx

• AssignCard(policyID, bankName, encryptedCardNumber, email, startDate, reportActionID)

WorkspaceCompanyCardsSettingsPage.tsx

WorkspaceCompanyCardFeedSelectorPage.tsx

WorkspaceMemberNewCardPage.tsx

• OpenPolicyCompanyCardsFeed(policyID, bankName)
• SetCardExportAccount(cardID, exportAccountDetails)
• SetCardName(cardID, cardName)

CardSelectionStep.tsx

• OpenPolicyCompanyCardsFeed() called earlier in the flow should already load the list of cards 🤔

[narefyev91]

Hi, I'm Nicolay from Callstack - expert contributor group - will help here as well (from tomorrow).
Will pick:

• WorkspaceCompanyCardsSettingsPage.tsx
• WorkspaceMemberNewCardPage.tsx
  OpenPolicyCompanyCardsFeed(policyID, bankName)
  SetCardExportAccount(cardID, exportAccountDetails)
  SetCardName(cardID, cardName)

[joekaufmanexpensify]

Assigned!

[VickyStash]

@robertjchen I have a question about reportActionID for this API call:
AssignCard(policyID, bankName, encryptedCardNumber, email, startDate, reportActionID).

Is it for this message? Should I optimistically create it?

I'm asking cause it looks like we don't create similar messages optimistically while issuing Expensify Cards.
^^ @mountiny

[robertjchen]

Interesting! That's a good point- if these messages are not being optimistically created, then the reportActionID is not needed 👍

[mountiny]

@robertjchen I think it's a bit different thought, right? With Expensify cards, we have to talk to Marqeta, a third-party service, and so there is a higher chance of the call with fail, so we do not create the actions optimistically. In this case, when we already have the list of the available cards, there are fewer things that can cause it to fail, so I think we could consider adding these optimistically; what do you think, @robertjchen?

[robertjchen]

That makes sense, that context definitely helps!

Since we already have all the info we need in Onyx at time of assignment, we can definitely do it optimistically which would make for a better user experience

[mountiny]

@VickyStash Feel free to add the optimistic reportActionID param to the api call and create the action optimistically and we can add it to BE

[VickyStash]

@robertjchen Could you say what action name this optimistic report action should have? I'm talking about the one created during AssignCard API call.

[robertjchen]

@VickyStash It would be CARDASSIGNED

[VickyStash]

I've prepared a Draft PR with:

• AssignCard API call
• Plain implementation of RequestFeedSetup API call
• Support of CARDASSIGNED report action display
• TODOs resolution

@robertjchen Please, let us know when RequestFeedSetup is deployed so we can start extensive testing of the functionality with the real data.

[robertjchen]

Yes, it appears to be under review at the moment 👍

[dylanexpensify]

Making progress

[VickyStash]

Updates:

• Updated params passed to RequestFeedSetup
• Waiting for API fixes

[melvin-bot]

Triggered auto assignment to @strepanier03 (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[dylanexpensify]

Reassigning as I head to parental leave next week! Thanks Sheena!

[allgandalf]

♻️ PR was merged

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.51-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [NoQA] [3rd Party Feeds] Workspace feeds clean up #49928

If no regressions arise, payment will be issued on 2024-10-29. 🎊

For reference, here are some details about the assignees on this issue:

• @VickyStash does not require payment (Contractor)
• @narefyev91 does not require payment (Contractor)
• @allgandalf requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allgandalf] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[allgandalf]

No checklist here, this belongs to a project, Only payment remains 🙏 (This is a 3rd party feed project and not direct feed so...)

[mountiny]

$250 to @allgandalf

[allgandalf]

🤣 i wonder what you are doing in 🇯🇵 these days

[mountiny]

psst

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA] [3rd Party Feeds] Follow-up: Move company cards related functions to CompanyCards file #51080

If no regressions arise, payment will be issued on 2024-10-30. 🎊

For reference, here are some details about the assignees on this issue:

• @VickyStash does not require payment (Contractor)
• @narefyev91 does not require payment (Contractor)
• @allgandalf requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allgandalf] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[allgandalf]

No checklist, payment summary here

[mountiny]

New feature so no checklist needed here