[HOLD for payment 2024-10-24] [$50] Input in Rules page have extra space

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.40-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dukenv0307
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1727365911986139

Action Performed:

1. Create a workspace
2. Go to More features -> enable Rules, Workflows
3. Go to Workflows -> add approvals
4. Go to Rules
5. Try to edit some value on Rules page
   6, Observe input fields

Expected Result:

The input style in the Rules page must be consistent with other pages.

Actual Result:

The input fields in the rules page all have extra space compared to the header title.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mov

invite member form:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021841805616678305134
• Upwork Job ID: 1841805616678305134
• Last Price Increase: 2024-10-10
• Automatic offers:
• nkdengineer | Contributor | 104358672

Issue Owner

Current Issue Owner: @Christinadobrzyn

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The input fields in the rules page all have extra space compared to the header title.

What is the root cause of that problem?

We have some extra padding or margin in Rules page here, here,.. and some places

App/src/pages/workspace/rules/RulesAutoApproveReportsUnderPage.tsx

Line 55 in 2e21203

style={[styles.flexGrow1, styles.mh5, styles.mt5]}

App/src/pages/workspace/rules/RulesAutoPayReportsUnderPage.tsx

Line 64 in 2e21203

style={[styles.flexGrow1, styles.mh5, styles.mt5]}

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

We should remove styles.mt5 and styles.pt3 in those places

And in other places with excess space

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Input in Rules page have extra space

What is the root cause of that problem?

We are adding extra styles.pt3 in these pages

App/src/pages/workspace/rules/RulesMaxExpenseAmountPage.tsx

Line 58 in 70a8a16

style={[styles.flexGrow1, styles.pt3, styles.ph5]}

What changes do you think we should make in order to solve the problem?

We should remove styles.pt3 from rule pages

App/src/pages/workspace/rules/RulesMaxExpenseAmountPage.tsx

Line 58 in 70a8a16

style={[styles.flexGrow1, styles.pt3, styles.ph5]}

Optional: We can use styles.flex1 instead of styles.flexGrow1 in rule pages

We should also remove styles.mt5 from all the rule pages

App/src/pages/workspace/rules/RulesRandomReportAuditPage.tsx

Line 53 in 70a8a16

style={[styles.flexGrow1, styles.mh5, styles.mt5]}

App/src/pages/workspace/rules/RulesAutoPayReportsUnderPage.tsx

Line 64 in 70a8a16

style={[styles.flexGrow1, styles.mh5, styles.mt5]}

App/src/pages/workspace/rules/RulesAutoApproveReportsUnderPage.tsx

Line 55 in 70a8a16

style={[styles.flexGrow1, styles.mh5, styles.mt5]}

What alternative solutions did you explore? (Optional)

[dukenv0307]

@dylanexpensify I report this bug so I can help take it as C+

[melvin-bot]

@dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@dylanexpensify Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021841805616678305134

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

[melvin-bot]

Upwork job price has been updated to $50

[dylanexpensify]

Pending proposals

[melvin-bot]

@Pujan92, @dylanexpensify Eep! 4 days overdue now. Issues have feelings too...

[Pujan92]

@dylanexpensify I report this bug so I can help take it as C+

@dukenv0307 I think we should not ask to assign to the issue as mentioned here

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[Pujan92]

As this is a straight forward change and we need to take out mt5 and pt3 from sub rules page, we can move with @nkdengineer's proposal as they are the first here.

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @francoisl, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dylanexpensify]

Reassigning as I head to parental leave next week! Thanks Christina!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.49-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Input in Rules page have extra space #50619

If no regressions arise, payment will be issued on 2024-10-24. 🎊

For reference, here are some details about the assignees on this issue:

• @Pujan92 requires payment through NewDot Manual Requests (REQUESTED)
• @nkdengineer requires payment automatic offer (Contributor)(PAID)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Pujan92] The PR that introduced the bug has been identified. Link to the PR:
• [@Pujan92] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Pujan92] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Pujan92] Determine if we should create a regression test for this bug.
• [@Pujan92] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: NA

[Christinadobrzyn]

Just checking on the payment- I see three contributors set for payment but only two assigned to this GH. It looks like the payment should only be to @Pujan92 and @nkdengineer is that correct?

Moving to daily as to not missing the payment date

[Christinadobrzyn]

@Pujan92 @nkdengineer do we need a regression test for this?

[Pujan92]

@Christinadobrzyn I don't think it requires regression test.

[Christinadobrzyn]

Payment day - paid out based on this payment summary - #49823 (comment)

@Pujan92 can you please request payment through NewDot?

[Pujan92]

@Christinadobrzyn requested, Thanks :)

[Christinadobrzyn]

Thanks @Pujan92! Closing this as complete. Payment summary here

[garrettmknight]

$50 approved for @Pujan92