-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-10-24] [$250] Saved search- Default search name in dropdown button shows policy ID when reopening search #50223
Comments
Triggered auto assignment to @OfstadC ( |
We think that this bug might be related to #wave-control |
@OfstadC FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
Edited by proposal-police: This proposal was edited at 2024-10-04 16:00:16 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.Default search name in dropdown button shows policy ID when reopening search What is the root cause of that problem?Here we use App/src/pages/Search/SearchTypeMenu.tsx Line 223 in 7d66ba7
and we get this searchName from here.
It works fine when we use the rename feature. Otherwise, the searchName will be:
What changes do you think we should make in order to solve the problem?We should only use pseudocode
Result Screen.Recording.2024-10-04.at.9.02.49.PM.movWhat alternative solutions did you explore? (Optional)We can also do this check inside |
ProposalPlease re-state the problem that we are trying to solve in this issue.Saved search name shows policyID when selecting it from the popover. What is the root cause of that problem?I think there are 2 problems here. When we save a new search filter, the query and name will be the same, and if we switch to a workspace before creating the filter, the policyID will be included as the query and name. App/src/pages/Search/AdvancedSearchFilters.tsx Lines 261 to 263 in 99f280b
App/src/libs/actions/Search.ts Lines 54 to 65 in 99f280b
Selecting the saved search from the popover will update the route params, query and name, from the saved search query and name, in our case, it will be the same. The first problem is the inconsistent name logic between the search type button text, and the saved search text in the popover. The search type button text always uses the name if it exists, App/src/pages/Search/SearchTypeMenu.tsx Lines 222 to 223 in 99f280b
while the saved search text uses the name if the value is different than the query. If it's the same, it will build the name using App/src/pages/Search/SearchTypeMenu.tsx Lines 115 to 119 in 99f280b
The second issue is Lines 766 to 769 in 99f280b
What changes do you think we should make in order to solve the problem?We can update the
But we can also update the name logic to make it consistent. App/src/pages/Search/SearchTypeMenu.tsx Lines 222 to 223 in 99f280b
|
@OfstadC Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Added this to Wave Control - posted in Slack for confirmation |
Job added to Upwork: https://www.upwork.com/jobs/~021843666631417893773 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox ( |
Can anyone reproduce this issue on the latest main? |
Still reproducible. a.mp4 |
Thanks for all the proposals. Based on the expected behavior for this issue is that 🎀 👀 🎀 C+ reviewed |
Triggered auto assignment to @tgolen, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
📣 @suneox 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @Nodebrute 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.49-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-10-24. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
@suneox Could you please complete the BZ checklist? Thank you ! 😃 |
Checklist
|
Payment Summary
|
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.44-7
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): applausetester+pso@applause.expensifail.com
Issue reported by: Applause Internal Team
Action Performed:
Expected Result:
The search name in the dropdown button will not show policy ID.
Actual Result:
The search name in the dropdown button shows policy ID, while the search name in the list does not have policy ID.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6624120_1728029543489.ScreenRecording_10-04-2024_16-03-38_1.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @OfstadCThe text was updated successfully, but these errors were encountered: