-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] Pay Someone - Wallet page opens when refreshing in "Validate your account" page #50285
Comments
Triggered auto assignment to @slafortune ( |
@slafortune FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
Edited by proposal-police: This proposal was edited at 2024-10-05 16:08:40 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.The DM chat page changes to Wallet page after refreshing in "Validate your account" page What is the root cause of that problem?
App/src/components/SettlementButton/index.tsx Line 193 in 99f280b
which will be mapped to wallet page. What changes do you think we should make in order to solve the problem?
instead. What alternative solutions did you explore? (Optional) |
regression from #50169 #49523 @ikevin127 @cretadn22 |
IMO, I don't think this issue is a regression from that PR, as the issue is more of an improvement, and we can't reproduce the same behavior in production for comparison. |
ProposalPlease re-state the problem that we are trying to solve in this issue.Page behind RHP changes to wallet page after refresh while on the wallet verify account page. What is the root cause of that problem?By default, wallet verify account page is mapped to the wallet page. App/src/libs/Navigation/linkingConfig/CENTRAL_PANE_TO_RHP_MAPPING.ts Lines 28 to 40 in 99f280b
So, refreshing it will show the matching route, that is the wallet page. What changes do you think we should make in order to solve the problem?We can pass backTo when opening the wallet verify account page, App/src/components/SettlementButton/index.tsx Line 193 in 99f280b
so it will be used as the matching screen. In our case, the backTo is the pay someone confirm page which will return a report screen as the matching screen. App/src/libs/Navigation/linkingConfig/getAdaptedStateFromPath.ts Lines 112 to 125 in 99f280b
But there is currently another bug where the backTo as the matching screen doesn't work which should be handled here. |
@slafortune Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@lanitochka17 Did you verify the account? how did you refresh? I'm not surprised that you land back on the wallet page - since you requested to pay someone but don't have anything to pay them with - you need to enter it. |
Issue is still reproducible Screen.Recording.2024-10-09.at.8.43.09.in.the.evening.mp4 |
@slafortune Huh... This is 4 days overdue. Who can take care of this? |
Job added to Upwork: https://www.upwork.com/jobs/~021845915923804552896 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov ( |
@slafortune, @alitoshmatov Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@alitoshmatov did you have a chance to review the proposals? |
@slafortune @alitoshmatov this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@slafortune, @alitoshmatov Still overdue 6 days?! Let's take care of this! |
@alitoshmatov bump - did you have a chance to review the proposals? |
@slafortune, @alitoshmatov Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.45-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): dave0123seife@gmail.com
Issue reported by: Applause - internal Team
Action Performed:
Expected Result:
Wallet page is not opened. DM chat is shown
Actual Result:
The DM chat page changes to Wallet page after refreshing in "Validate your account" page
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6625141_1728100368377.Screen_Recording_2024-10-05_at_6.35.48_in_the_morning.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @alitoshmatovThe text was updated successfully, but these errors were encountered: