[HOLD for payment 2024-11-07] [$250] Task description is covered by the keyboard pop up

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.45-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @danielrvidal
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1728321152515439

Action Performed:

1. Signed up for a new account
2. Selected Get paid by my employer
   3.Tap into the Concierge DM
   4.Tap into the first task

Expected Result:think

Keyboard should not pop up by default

Actual Result:

keyboard is pulled up by default, which makes the task description unreadable.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

NYOA0685.1.MP4

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021843564581975607149
• Upwork Job ID: 1843564581975607149
• Last Price Increase: 2024-10-08
• Automatic offers:
• rojiphil | Reviewer | 104340068
• nkdengineer | Contributor | 104340070

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[shahinyan11]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Task description is covered by the keyboard pop up

What is the root cause of that problem?

Here we do not prevent autofocus when the parent report actions is a task action.

What changes do you think we should make in order to solve the problem?

We should prevent autofocus when parent report action is a task action. To do that we can update this line like bellow

(shouldFocusInputOnScreenFocus || (isEmptyChat && !ReportActionsUtils.isTransactionThread(parentReportAction) && !ReportActionsUtils.isTaskAction(parentReportAction))) &&

What alternative solutions did you explore? (Optional)

[nkdengineer]

Edited by proposal-police: This proposal was edited at 2024-10-08 06:24:49 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

keyboard is pulled up by default, which makes the task description unreadable.

What is the root cause of that problem?

shouldAutoFocus is true for the onboarding task report because this is an empty chat that focuses on the composer and keyboard

App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx

Lines 302 to 307 in bcc6263

	const shouldAutoFocus =
	!modal?.isVisible &&
	Modal.areAllModalsHidden() &&
	isFocused &&
	(shouldFocusInputOnScreenFocus || (isEmptyChat && !ReportActionsUtils.isTransactionThread(parentReportAction))) &&
	shouldShowComposeInput;

What changes do you think we should make in order to solve the problem?

We can add the check if the report is a task report, and we can prevent autofocus on the composer

const [report] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${reportID}`);
const shouldAutoFocus =
    !modal?.isVisible &&
    Modal.areAllModalsHidden() &&
    isFocused &&
    (shouldFocusInputOnScreenFocus || (isEmptyChat && !ReportActionsUtils.isTransactionThread(parentReportAction) && !ReportUtils.isTaskReport(report))) &&
    shouldShowComposeInput;

App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx

Lines 302 to 307 in bcc6263

	const shouldAutoFocus =
	!modal?.isVisible &&
	Modal.areAllModalsHidden() &&
	isFocused &&
	(shouldFocusInputOnScreenFocus || (isEmptyChat && !ReportActionsUtils.isTransactionThread(parentReportAction))) &&
	shouldShowComposeInput;

OPTIONAL: We can use !ReportActionsUtils.isCreatedTaskReportAction(parentReportAction) to replace for !ReportUtils.isTaskReport(report)

What alternative solutions did you explore? (Optional)

Or we can only prevent auto-focus if the task report is the onboarding task report. To do that we can get the onboarding data from nvp_introSelected and check if the current reportID is in the list value of nvp_introSelected data.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021843564581975607149

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)

[danielrvidal]

@rojiphil, can you prioritize reviewing this one? It is impacting a CRITICAL flow.

[rojiphil]

Thanks for your proposals.
@shahinyan11 parentReportAction would have an action name ADDCOMMENT. So, using isTaskAction would not work here.
@nkdengineer proposal LGTM as we can use isTaskReport.
Additionally, we can migrate to useOnyx from withOnyx for the Onyx values used in ComposerWithSuggestions
🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @lakchote, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[lakchote]

@nkdengineer's proposal LGTM.

[melvin-bot]

📣 @rojiphil 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[nkdengineer]

@lakchote I created the PR here but this issue was just fixed by this PR 2 hours ago.

[melvin-bot]

@JmillsExpensify, @rojiphil, @lakchote, @nkdengineer Huh... This is 4 days overdue. Who can take care of this?

[nkdengineer]

Looks like this PR has been reverted, I will open my PR soon

[anmurali]

@nkdengineer - do you have an update here?

[danielrvidal]

@nkdengineer can you please update this one asap? @lakchote if we don't hear back soon with an update can we look for another proposal please?

[lakchote]

@danielrvidal sure!

@nkdengineer if you don't raise your PR today/give updates I'll put the label to look for proposals this afternoon.

[nkdengineer]

@lakchote We're waiting for your response in the PR.

[lakchote]

@lakchote We're waiting for your response in the PR.

Answered here

[lakchote]

Reached out in DM to @nkdengineer to see if he can push the fix that should make his PR mergeable today.

[nkdengineer]

@lakchote I will be available in a few hours.

[nkdengineer]

@lakchote I updated. waiting for the running test.

[lakchote]

PR has been merged.

[danielrvidal]

Awesome, thank you!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.55-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Task description is covered by the keyboard pop up #50544

If no regressions arise, payment will be issued on 2024-11-07. 🎊

For reference, here are some details about the assignees on this issue:

• @rojiphil requires payment automatic offer (Reviewer)
• @nkdengineer requires payment automatic offer (Contributor)

[melvin-bot]

@rojiphil @JmillsExpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[rojiphil]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment:

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: Not Required. The existing checklist is good enough to capture such issues.

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal

Precondition:

Test:

Note: The tests are applicable only for mWeb and native platforms.

1. Sign up with a new account
2. Complete onboarding step using Track and budget expenses
3. Navigate to Concierge DM if needed
4. Tap on Track an expense task to navigate to the task report
5. Verify that the keyboard is not displayed

Do we agree 👍 or 👎

[lakchote]

Has the payment been processed here @JmillsExpensify?

[JmillsExpensify]

Payment summary:

• Contributor: $250 @nkdengineer via Upwork
• Reviewer: $250 @rojiphil via Upwork

[JmillsExpensify]

Contributors paid out and regression test linked to this issue. Closing this out.