-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-10-30] QBD - Empty link in RHP when network is disconnected while QBD setup is loading #50548
Comments
Triggered auto assignment to @strepanier03 ( |
Triggered auto assignment to @techievivek ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
We think that this bug might be related to #wave-control |
The project is still in beta so I don't think it's a DB. |
cc @ZhenjaHorbach @lakchote ^ |
It's not really clear what the expected result is |
It's not a blocker as it's behind beta indeed. |
I'd prefer to not show infinite loading when offline, as it would mistakenly make the user think something is going to happen and the link will show. We should find a way to notify him he's offline, and as such, cannot get the setup link. Let's tag @Expensify/design to see if we already had to handle this situation before, and to have their point of view. |
Yeah I agree with not showing a loader forever—that doesn't seem super helpful. Here are a couple ideas about how to handle this: 1) Replace the link with an offline indicatorIf we can automatically update the link box with the link when it's available, this feels like the smoothest option. 2) Blast 'em with our blocking offline patternIf we can't automatically update the link/we actually need them to just try again once they come back online, this pattern might work best. cc @dubielzyk-expensify for thoughts and preferences. |
2nd idea looks promising to me 👀 |
I think the 2nd idea just for the simplicity and consistency 👍 |
I think the 2nd makes it really clear but the 1st one looks more friendly. |
Thanks for the proposals @dannymcclain! If the user comes back online, we can fetch the setup link again, thus making option #1 viable. Code will need to be adjusted either way to take into account going offline cc @hoangzinh : Example for option #1:
I'm with @strepanier03, option #1 looks more friendly, but I don't have any hard preference. If the option #2 is more consistent in terms of what we're doing in our design patterns, let's do #2 as consistency is key. |
ProposalPlease re-state the problem that we are trying to solve in this issue.RHP is loaded with empty link. What is the root cause of that problem?
What changes do you think we should make in order to solve the problem?Regarding #50548 (comment) 1. Replace the link with an offline indicatorUpdate Logics inside this
Add a new text App/src/pages/workspace/accounting/qbd/QuickBooksDesktopSetupPage.tsx Lines 66 to 71 in abdfb72
2. Blast 'em with our blocking offline patternWrap this part inside What alternative solutions did you explore? (Optional) |
Totally down to go with the full offline screen to keep things consistent across the app. 👍 |
@lakchote Given this is an edge case, can I put this issue at the end of the queue and focus on other QBD issues? |
Sure! |
@lakchote @dannymcclain If we already have |
🤔 Hmm, I don't think we do if we already have the link. Obviously the user might run into problems opening the link if they're truly offline, but IMO that's not really on us. Open to other perspectives though! |
Yes, I have same thought. |
@ZhenjaHorbach, I agree with @dannymcclain and @hoangzinh. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-10-30. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.47-1
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Issue was found when executing this PR: #50216
Email or phone of affected tester (no customers): applausetester+pso@applause.expensifail.com
Issue reported by: Applause Internal Team
Action Performed:
Expected Result:
RHP will show that the page is offline.
Actual Result:
RHP is loaded with empty link.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6630106_1728513620793.20241010_063732.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @strepanier03The text was updated successfully, but these errors were encountered: