-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] Header - Header does not display "No Action Required" when payment is disabled #50785
Comments
Triggered auto assignment to @OfstadC ( |
@OfstadC FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
Edited by proposal-police: This proposal was edited at 2024-10-16 03:35:57 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.Header - Header does not display "No Action Required" when payment is disabled What is the root cause of that problem?When we create the next step header for the expense, we pass Line 2170 in f737e9b
Lines 112 to 142 in f737e9b
What changes do you think we should make in order to solve the problem?We should check if the const optimisticNextStep = NextStepUtils.buildNextStep(
iouReport,
policy?.reimbursementChoice === CONST.POLICY.REIMBURSEMENT_CHOICES.REIMBURSEMENT_NO ? CONST.REPORT.STATUS_NUM.CLOSED : CONST.REPORT.STATUS_NUM.OPEN,
); ResultScreen.Recording.2024-10-15.at.06.10.29.movWhat alternative solutions did you explore? (Optional)We can also hide the next step header when the const optimisticNextStep = policy?.reimbursementChoice === CONST.POLICY.REIMBURSEMENT_CHOICES.REIMBURSEMENT_NO ? null : NextStepUtils.buildNextStep(
iouReport,
CONST.REPORT.STATUS_NUM.OPEN,
); |
ProposalPlease re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
Line 2170 in f737e9b
What changes do you think we should make in order to solve the problem?
Line 2170 in f737e9b
to:
to make sure our optimistic data will match BE data. What alternative solutions did you explore? (Optional)
|
@OfstadC Can you confirm whether the expected behavior is: The header should display "No further action required." Because, in online mode, there is no header is displayed. |
I think this is a regression from #49837 |
@OfstadC Eep! 4 days overdue now. Issues have feelings too... |
Job added to Upwork: https://www.upwork.com/jobs/~021848784178852136813 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 ( |
The header shouldn't say "waiting to automatically submit..." since it's already been submitted. 😅 |
🎀👀🎀 C+ reviewed |
Triggered auto assignment to @mjasikowski, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
@mjasikowski @OfstadC I want to confirm the expectation here: When creating the expense, we build the optimistic data for reportNextStep Line 2170 in f737e9b
and it's But BE returns the empty message, so the header doesn't show anything So what is the expectation here:
|
@dukenv0307 this seems to be a backend bug - "No further action required." should be returned, but the message returned is empty. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.49-0
Reproducible in staging?: Y
Reproducible in production?: Y
Issue was found when executing this PR: #49837
Email or phone of affected tester (no customers): biruknew45+1562@gmail.com
Issue reported by: Applause Internal Team
Action Performed:
Expected Result:
The header should display "No further action required."
Actual Result:
The header displays "Waiting for your expense(s) to automatically submit."
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6635003_1728981428894.1__1_.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @dukenv0307The text was updated successfully, but these errors were encountered: