[$250] iOS Hybrid - Composer - Keyboard does not reopen after dismissing the context menu

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.49-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh081006@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch New Expensify app
2. Go to DM
3. Send a message
4. With keyboard up, long press on the message
5. Tap outside the context menu

Expected Result:

The keyboard will reopen after dismissing the context menu (production behavior and staging mweb behavior)

Actual Result:

The keyboard does not reopen after dismissing the context menu

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6635613_1729019252899.ScreenRecording_10-16-2024_03-02-03_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021846522126717879513
• Upwork Job ID: 1846522126717879513
• Last Price Increase: 2024-10-16

Issue Owner

Current Issue Owner: @Ollyws

[melvin-bot]

Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[marcaaron]

Reproducible in production?: Y

So, not a blocker right?

[lanitochka17]

sorry, my mistake.
Reproducible in production?: N

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021846522126717879513

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The keyboard does not reopen after dismissing the context menu

What is the root cause of that problem?

When users press + button, we will blur the composer

App/src/pages/home/report/ReportActionCompose/ReportActionCompose.tsx

Line 229 in 4a25c36

composerRef.current?.blur();

Even we have the logic to refocus in

App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx

Line 677 in 4a25c36

focus(true);

but it's prevented by willBlurTextInputOnTapOutside, that is set to false in native device

App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx

Lines 669 to 671 in 4a25c36

	if (!((willBlurTextInputOnTapOutside || shouldAutoFocus) && !isNextModalWillOpenRef.current && !modal?.isVisible && isFocused && (!!prevIsModalVisible || !prevIsFocused))) {
	return;
	}

-> the focus logic doesn't run

What changes do you think we should make in order to solve the problem?

Since we don't want to call focus when the modal get closed

App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx

Lines 666 to 668 in 4a25c36

	// We want to focus or refocus the input when a modal has been closed or the underlying screen is refocused.
	// We avoid doing this on native platforms since the software keyboard popping
	// open creates a jarring and broken UX.

-> we shouldn't blur it if willBlurTextInputOnTapOutside is false

We can update onAddActionPressed

    const onAddActionPressed = useCallback(() => {
        if (!willBlurTextInputOnTapOutside) {
            isKeyboardVisibleWhenShowingModalRef.current = !!composerRef.current?.isFocused();
            return;
        }
        composerRef.current?.blur();
    }, []);

What alternative solutions did you explore? (Optional)

We face the same issue when users long press on report action so we can apply the same solution in

App/src/pages/home/report/ReportActionItem.tsx

Line 342 in 4a25c36

ReportActionComposeFocusManager.blurAll();

[flodnv]

@daledah any idea which PR caused this?

[daledah]

@flodnv I think we changed it on purpose here #48415

[daledah]

@flodnv If we decide to hide the keyboard, we can refactor/remove this hook

App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx

Line 655 in 4a25c36

useEffect(() => {

since it's used to focus or refocus the input when a modal has been closed

[rezkiy37]

It is not a bug. This is the expected behavior now. That's a PR where it was changed. Proposal.

[daledah]

@rezkiy37 Should we remove this hook #50830 (comment)

[rezkiy37]

@rezkiy37 Should we remove this hook #50830 (comment)

Just to clarify: this is the expected result.

Actual Result:
The keyboard does not reopen after dismissing the context menu

So I don't think we should touch something. So just close the issue.

[flodnv]

Thanks for the clarification and details @rezkiy37, I agree with you 👍

[daledah]

@rezkiy37

The keyboard does not reopen after dismissing the context menu

That why I think we can remove this hook. It's used to re-focus, but you change willBlurTextInputOnTapOutside to false on native and mweb -> the logic here never runs

App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx

Lines 666 to 668 in 4a25c36

	// We want to focus or refocus the input when a modal has been closed or the underlying screen is refocused.
	// We avoid doing this on native platforms since the software keyboard popping
	// open creates a jarring and broken UX.