Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] IOS Hybrid - No image preview is shown in composer #50839

Closed
1 of 6 tasks
lanitochka17 opened this issue Oct 15, 2024 · 15 comments
Closed
1 of 6 tasks

[$250] IOS Hybrid - No image preview is shown in composer #50839

lanitochka17 opened this issue Oct 15, 2024 · 15 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@lanitochka17
Copy link

lanitochka17 commented Oct 15, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.49-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+en@applause.expensifail.com
Issue reported by: Applause - Internal Team

Issue found when executing PR #50047

Action Performed:

  1. Open the Expenisfy Hybrid app
  2. Sign into a valid account and access the ND features within the app
  3. Open any chat room / page with Live Markdown input
    4, Enter inline image markdown. For example: test demo imagetest

Expected Result:

User expects to see an image preview in the composer

Actual Result:

No image preview is seen

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

preview_in_composer_

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021847324912015488495
  • Upwork Job ID: 1847324912015488495
  • Last Price Increase: 2024-10-25
Issue OwnerCurrent Issue Owner: @dukenv0307
@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 15, 2024
Copy link

melvin-bot bot commented Oct 15, 2024

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@lanitochka17
Copy link
Author

@isabelastisser FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@isabelastisser isabelastisser added External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Oct 18, 2024
@melvin-bot melvin-bot bot added the Overdue label Oct 18, 2024
@melvin-bot melvin-bot bot changed the title IOS Hybrid - No image preview is shown in composer [$250] IOS Hybrid - No image preview is shown in composer Oct 18, 2024
Copy link

melvin-bot bot commented Oct 18, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021847324912015488495

Copy link

melvin-bot bot commented Oct 18, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

@melvin-bot melvin-bot bot removed the Overdue label Oct 18, 2024
@VickyStash
Copy link
Contributor

@isabelastisser It looks like the inline images preview was implemented on the web platforms only, it's mentioned in the PR.
This ticket reports a problem on iOS native, where this functionality is not supported I believe. So I'm not sure if it's a bug.
cc @Skalakid since he is the author of the initial PR.

@melvin-bot melvin-bot bot added the Overdue label Oct 21, 2024
@isabelastisser
Copy link
Contributor

@dukenv0307 @Skalakid, can you please review the comment above and follow up? Thanks!

Copy link

melvin-bot bot commented Oct 21, 2024

@isabelastisser, @dukenv0307 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@dukenv0307
Copy link
Contributor

@Skalakid Do you think it's the bug?

@melvin-bot melvin-bot bot removed the Overdue label Oct 22, 2024
@isabelastisser
Copy link
Contributor

Bump @dukenv0307. I DM'd you for visibility. Thanks!

@dukenv0307
Copy link
Contributor

@isabelastisser I think it's not a bug, but we need to wait for @Skalakid's response

@dukenv0307
Copy link
Contributor

I already asked him in #50839 (comment)

@Skalakid
Copy link
Contributor

Sorry, I missed the notification about this issue. As @VickyStash said, the inline image features are implemented for the web only for now. So it's not a bug. We are still working on adding this feature to native platforms

Copy link

melvin-bot bot commented Oct 25, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Oct 25, 2024
@isabelastisser
Copy link
Contributor

Thanks for clarifying, @Skalakid1 Closing.

@melvin-bot melvin-bot bot removed the Overdue label Oct 25, 2024
Copy link

melvin-bot bot commented Oct 25, 2024

@isabelastisser Be sure to fill out the Contact List!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
Status: Done
Development

No branches or pull requests

5 participants