-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] Workspace list is opened when opening a WS share code without any access to it #51000
Comments
Triggered auto assignment to @adelekennedy ( |
We think this issue might be related to the #collect project. |
ProposalPlease re-state the problem that we are trying to solve in this issue.WS list is opened when trying to open a WS shared link without any access. What is the root cause of that problem?The WS share link actually points to a WS join link (e.g., Opening the join link will send a join request and the user will be navigated to the WS list as expected. App/src/pages/workspace/WorkspaceJoinUserPage.tsx Lines 53 to 60 in 987ff1b
The real problem here is that, the WS that we are trying to join doesn't appear on the WS list page. It's because we are filtering any policy that doesn't have role. Lines 183 to 188 in 987ff1b
It's to solve this issue. A WS that we are trying to join only have this information. Because there is no role information, the policy isn't shown. What changes do you think we should make in order to solve the problem?If we look at the shouldShowPolicy condition, we already check for Lines 183 to 188 in 987ff1b
I think if a WS is pending join, then we can always show it, skipping the other conditions.
|
Job added to Upwork: https://www.upwork.com/jobs/~021847411075396403416 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane ( |
Thanks for the proposal @bernhardoj Proposal from @bernhardoj looks good to me. 🎀 👀 🎀 C+ reviewed |
Triggered auto assignment to @neil-marcellini, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
little bump @neil-marcellini for the internal review |
@sobitneupane, @neil-marcellini, @adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.50-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
Found when validation PR #50875
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:
Preconditions: Uninstall ND app. A Gmail user should be at it's own workspace share code page on web.
Expected Result:
I should be navigated to the "it's not here" page with an option to request access.
Actual Result:
Workspace list is opened when opening a WS share code without any access to it.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6637266_1729141374861.VQJQ8044.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @sobitneupaneThe text was updated successfully, but these errors were encountered: