-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$125] Update the Onboarding steps for "Chat and split bills with friends" #51215
Comments
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 ( |
Edited by proposal-police: This proposal was edited at 2024-10-22 02:23:15 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.Update the Onboarding steps for "Chat and split bills with friends" What is the root cause of that problem?Changes Request What changes do you think we should make in order to solve the problem?We need update the
RESULT What alternative solutions did you explore? (Optional) |
Edited by proposal-police: This proposal was edited at 2024-10-22 05:50:49 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.Update the Onboarding steps for "Chat and split bills with friends" What is the root cause of that problem?General Update What changes do you think we should make in order to solve the problem?I propose to include this task with Spanish translation, and translate all the other onboarding tasks to Spanish as well(could be handled as separate PR if needed). {
type: 'splitExpense',
autoCompleted: false,
title: Translate('onboarding.tasks.splitExpense.title'),
description:
Translate('onboarding.tasks.splitExpense.description'),
}, Lines 4819 to 4834 in 04214cd
Add this to en.ts here tasks: {
splitExpense: {
title: 'Split an expense',
description:
'*Split an expense* right in your chat with one or more friends.\n' +
'\n' +
'Here’s how to request money:\n' +
'\n' +
'1. Hit the green *+* button.\n' +
'2. Choose *Start chat*.\n' +
'3. Enter any email, SMS, or name of who you want to split with.\n' +
'4. From within the chat, hit the *+* button on the message bar, and hit *Split expense*.\n' +
'5. Create the expense by selecting Manual, Scan or Distance.\n' +
'\n' +
'Feel free to add more details if you want, or just send it off. Let’s get you paid back!',
}
} and update es.ts accordingly.
What alternative solutions did you explore? (Optional)Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job. |
Triggered auto assignment to @danielrvidal ( |
@danielrvidal , added I assigned myself as BZ since I was tagged and have context |
@mallenexpensify I will be taking over as C+ reviewing the proposals. While we're waiting for confirmation on copy, I will start reviewing the proposals. |
Current assignee @mallenexpensify is eligible for the Bug assigner, not assigning anyone new. |
|
One more thing @ikevin127 this looks like a simple text update so I set it at $125. Let me know if I'm missing something |
Given that there's no mention about translations in the OP, the codebase shows no indication of translating any of the I think moving / translating all 🎀👀🎀 C+ reviewed |
Triggered auto assignment to @nkuoch, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
The copy looks good in the proposals. I was going to note Split expense should be bolded in #4 but it looks like the proposals account for that. I'm unassigning myself but please add me back if needed. |
Problem
The steps presented currently expose dated functionality and that isn't available in-app anymore. This causes user-confusion for anyone that selects that onboarding intent.
Solution
Update the onboarding steps for the Task -
Split an expense
to:Split an expense right in your chat with one or more friends.
Here’s how to request money:
Feel free to add more details if you want, or just send it off. Let’s get you paid back!
cc: @mallenexpensify @vitHoracek as we'll be tapping C+ for this
Issue Owner
Current Issue Owner: @ikevin127The text was updated successfully, but these errors were encountered: