Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$125] Update the Onboarding steps for "Chat and split bills with friends" #51215

Open
zsgreenwald opened this issue Oct 22, 2024 · 12 comments
Open
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Waiting for copy User facing verbiage needs polishing Weekly KSv2

Comments

@zsgreenwald
Copy link
Contributor

zsgreenwald commented Oct 22, 2024

Problem

The steps presented currently expose dated functionality and that isn't available in-app anymore. This causes user-confusion for anyone that selects that onboarding intent.

image

Solution

Update the onboarding steps for the Task - Split an expense to:

Split an expense right in your chat with one or more friends.

Here’s how to request money:

  1. Hit the green + button
  2. Choose "Start chat"
  3. Enter any email, SMS, or name of who you want to split with
  4. From within the chat, hit the + button on the message bar, and hit Split expense
  5. Create the expense by selecting Manual, Scan or Distance

Feel free to add more details if you want, or just send it off. Let’s get you paid back!

cc: @mallenexpensify @vitHoracek as we'll be tapping C+ for this

Issue OwnerCurrent Issue Owner: @ikevin127
@zsgreenwald zsgreenwald added External Added to denote the issue can be worked on by a contributor Daily KSv2 labels Oct 22, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 22, 2024
Copy link

melvin-bot bot commented Oct 22, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

@nyomanjyotisa
Copy link
Contributor

nyomanjyotisa commented Oct 22, 2024

Edited by proposal-police: This proposal was edited at 2024-10-22 02:23:15 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update the Onboarding steps for "Chat and split bills with friends"

What is the root cause of that problem?

Changes Request

What changes do you think we should make in order to solve the problem?

We need update the splitExpense here

                {
                    type: 'splitExpense',
                    autoCompleted: false,
                    title: 'Split an expense',
                    description:
                        '*Split an expense* right in your chat with one or more friends.\n' +
                        '\n' +
                        'Here’s how to request money:\n' +
                        '\n' +
                        '1. Hit the green *+* button.\n' +
                        '2. Choose *Start chat*.\n' +
                        '3. Enter any email, SMS, or name of who you want to split with.\n' +
                        '4. From within the chat, hit the *+* button on the message bar, and hit *Split expense*.\n' +
                        '5. Create the expense by selecting Manual, Scan or Distance.\n' +
                        '\n' +
                        'Feel free to add more details if you want, or just send it off. Let’s get you paid back!',
                },

RESULT

Screenshot 2024-10-22 at 10 47 45

What alternative solutions did you explore? (Optional)

@ChavdaSachin
Copy link
Contributor

ChavdaSachin commented Oct 22, 2024

Edited by proposal-police: This proposal was edited at 2024-10-22 05:50:49 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update the Onboarding steps for "Chat and split bills with friends"

What is the root cause of that problem?

General Update

What changes do you think we should make in order to solve the problem?

I propose to include this task with Spanish translation, and translate all the other onboarding tasks to Spanish as well(could be handled as separate PR if needed).
Something like....

                {
                    type: 'splitExpense',
                    autoCompleted: false,
                    title: Translate('onboarding.tasks.splitExpense.title'),
                    description:
                        Translate('onboarding.tasks.splitExpense.description'),
                },

App/src/CONST.ts

Lines 4819 to 4834 in 04214cd

{
type: 'splitExpense',
autoCompleted: false,
title: 'Split an expense',
description:
'*Split an expense* right in your chat with one or more friends.\n' +
'\n' +
'Here’s how to request money:\n' +
'\n' +
'1. Click the green *+* button.\n' +
'2. Choose *Split expense*.\n' +
'3. Scan a receipt or enter an amount.\n' +
'4. Add your friend(s) to the request.\n' +
'\n' +
'Feel free to add more details if you want, or just send it off. Let’s get you paid back!',
},

Add this to en.ts here

tasks: {
     splitExpense: {
          title: 'Split an expense',
          description: 
                 '*Split an expense* right in your chat with one or more friends.\n' +
                        '\n' +
                        'Here’s how to request money:\n' +
                        '\n' +
                        '1. Hit the green *+* button.\n' +
                        '2. Choose *Start chat*.\n' +
                        '3. Enter any email, SMS, or name of who you want to split with.\n' +
                        '4. From within the chat, hit the *+* button on the message bar, and hit *Split expense*.\n' +
                        '5. Create the expense by selecting Manual, Scan or Distance.\n' +
                        '\n' +
                        'Feel free to add more details if you want, or just send it off. Let’s get you paid back!',
          }
}

and update es.ts accordingly.

  • Translating everything related to onboarding tasks would additionally solve this issue as well

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Copy link

melvin-bot bot commented Oct 22, 2024

Triggered auto assignment to @danielrvidal (Waiting for copy), see https://stackoverflow.com/c/expensify/questions/7025/ for more details.

@mallenexpensify
Copy link
Contributor

@danielrvidal , added Waiting for copy for 👀 on copy in the OP.
@ikevin127 are you doing the work here as the contributor or will you be reviewing proposals and the PR?

I assigned myself as BZ since I was tagged and have context

@ikevin127
Copy link
Contributor

@mallenexpensify I will be taking over as C+ reviewing the proposals. While we're waiting for confirmation on copy, I will start reviewing the proposals.

@mallenexpensify mallenexpensify added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 22, 2024
Copy link

melvin-bot bot commented Oct 22, 2024

Current assignee @mallenexpensify is eligible for the Bug assigner, not assigning anyone new.

@mallenexpensify mallenexpensify changed the title Update the Onboarding steps for "Chat and split bills with friends" [$125] Update the Onboarding steps for "Chat and split bills with friends" Oct 22, 2024
Copy link

melvin-bot bot commented Oct 22, 2024

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

@mallenexpensify
Copy link
Contributor

One more thing @ikevin127 this looks like a simple text update so I set it at $125. Let me know if I'm missing something

@ikevin127
Copy link
Contributor

Given that there's no mention about translations in the OP, the codebase shows no indication of translating any of the ONBOARDING_MESSAGES as we keep them in CONST instead of translation files, I'd say let's go with @nyomanjyotisa's proposal as this is a simple copy replacement task.

I think moving / translating all ONBOARDING_MESSAGES would be out of scope for this issue. @ChavdaSachin if you want to do that you'd have a better chance in this issue, so I'd recommend you to post a proposal there.

🎀👀🎀 C+ reviewed

Copy link

melvin-bot bot commented Oct 22, 2024

Triggered auto assignment to @nkuoch, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@danielrvidal
Copy link
Contributor

The copy looks good in the proposals. I was going to note Split expense should be bolded in #4 but it looks like the proposals account for that. I'm unassigning myself but please add me back if needed.

@danielrvidal danielrvidal removed their assignment Oct 23, 2024
@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 23, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Waiting for copy User facing verbiage needs polishing Weekly KSv2
Projects
Status: No status
Development

No branches or pull requests

7 participants