-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] [OldDot & NewDot] Allow disabling auto renew freely if you haven't been billed at least once. #53382
Comments
Current assignee @trjExpensify is eligible for the NewFeature assigner, not assigning anyone new. |
Edited by proposal-police: This proposal was edited at 2024-12-02 14:59:59 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.Currently, users who attempt to toggle off auto-renew are shown a retention survey, even if they haven't been billed yet. This is confusing for new users who do not identify with the survey options, as they haven't experienced the product enough to provide meaningful feedback. What is the root cause of that problem?improvement What changes do you think we should make in order to solve the problem?Introduce a check to determine if the user has billing history (via account?.hasPurchases). If they do, navigate to the retention survey; otherwise, skip it.
as:
|
ProposalPlease re-state the problem that we are trying to solve in this issue.Users who have not been billed yet encounter a retention survey when attempting to disable the auto-renew feature. This is unnecessary and confusing because the retention survey options do not make sense for new users who have not incurred any charges. What is the root cause of that problem?The current logic for disabling auto-renew does not differentiate between users who have been billed and those who have not. As a result, all users are shown the retention survey regardless of their billing history. What changes do you think we should make in order to solve the problem?
Determine Billing Status:Add a check to determine if the user has been billed at least once. Modify handleAutoRenewToggle:Update the logic to bypass the retention survey if the user hasn't been billed yet:
|
@mananjadhav @rushatgabhane @mountiny I labelled this as internal, because the retention survey is also shown in this case on OldDot, and I suspect that simply skipping the survey isn't enough to actually disable autoRenew properly. Keen for a second opinion on that. |
Makes sense to me but I think the the contributors can also check out their solution if it works with purely frontend change. I am not sure if we require the the survey response in BE |
@Shahidullah-Muffakir maybe you can check then. :) |
@trjExpensify @mountiny I believe FE changes should be enough, as we can use Screen.Recording.2024-12-06.at.9.41.18.PM.mov |
Can you confirm that properly disables auto-renew? I guess, log-out and back in, or refresh or something? |
Yes, I tested it, and it's working properly! new.mp4 |
Job added to Upwork: https://www.upwork.com/jobs/~021866071159246990575 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale ( |
Great stuff! Let's get that moving forward then. @akinwale can you review the proposals, please? |
After reviewing both proposals, we can move forward with @Shahidullah-Muffakir's proposal since it was posted first and it reuses an approach that already exists in the codebase. 🎀👀🎀 C+ reviewed. |
Triggered auto assignment to @techievivek, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
📣 @Shahidullah-Muffakir You have been assigned to this job! |
This was deployed to production on 2024-12-18, so it will be due for payment on 2024-12-25. Happy holidays! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.69-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation: #convert thread
Action Performed:
NewDot
OldDot
Expected Result:
This is an improvement.
If the user hasn't been billed at least once, toggling off auto-renew should be allowed without having to complete the retention survey.
Actual Result:
The retention survey is shown to the user, which is confusing because none of the options make sense to a new user who hasn't been billed yet.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
FS here (internal)
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @akinwaleThe text was updated successfully, but these errors were encountered: