[$250] Onboarding - "Start a free trial" banner and button appear in Concierge then disappear

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.71-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): didjojdojjdidjo2@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Sign up with a new Gmail account (random email without +).
3. On onboarding purpose, choose Manage my team's expenses.
4. Select organization size.
5. Select an accounting.
6. Complete the onboarding.

Expected Result:

"Start a free trial" banner and button should appear consistently.

Actual Result:

After the onboarding is complete, "Start a free trial" banner (LHN) and button appear in Concierge.
Then, "Start a free trial" banner" disappears from Concierge report in LHN when #admins room shows up.
When switching to #admins and back to Concierge, "Start a free trial" banner (LHN) and button disappear from Concierge.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6683821_1733279795626.20241204_100133.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021864974056851982720
• Upwork Job ID: 1864974056851982720
• Last Price Increase: 2024-12-06

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @c3024

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @iwiznia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[twisterdotcom]

The button does appear, I just think the only issue is that the "Start a free trial" tip beside the room name for Concierge disappears when the #admins room appears:

53526.mp4

I wouldn't call it a deploy blocker.

[truph01]

Edited by proposal-police: This proposal was edited at 2024-12-05 04:36:14 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

After the onboarding is complete, "Start a free trial" banner (LHN) and button appear in Concierge.
Then, "Start a free trial" banner" disappears from Concierge report in LHN when #admins room shows up.
When switching to #admins and back to Concierge, "Start a free trial" banner (LHN) and button disappear from Concierge.

What is the root cause of that problem?

• The logic to display "Start a free trial" are:

App/src/components/LHNOptionsList/OptionRowLHN.tsx

Line 282 in 0e28aa4

{ReportUtils.isChatUsedForOnboarding(report) && <FreeTrial badgeStyles={[styles.mnh0, styles.pl2, styles.pr2, styles.ml1]} />}

App/src/pages/home/HeaderView.tsx

Line 292 in 0e28aa4

{!shouldUseNarrowLayout && isChatUsedForOnboarding && freeTrialButton}

both of them use ReportUtils.isChatUsedForOnboarding(report). But this function also use onboarding data:

App/src/libs/ReportUtils.ts

Lines 8293 to 8300 in 0e28aa4

	function isChatUsedForOnboarding(optionOrReport: OnyxEntry<Report> | OptionData): boolean {
	// onboarding can be an array or an empty object for old accounts and accounts created from olddot
	if (onboarding && !Array.isArray(onboarding) && !isEmptyObject(onboarding) && onboarding.chatReportID) {
	return onboarding.chatReportID === optionOrReport?.reportID;
	}
	return (optionOrReport as OptionData)?.isConciergeChat ?? isConciergeChatReport(optionOrReport);
	}

• If the onboarding data is updated, isChatUsedForOnboarding is not called again, so that the condition to display "Start a free trial" can be outdated.

What changes do you think we should make in order to solve the problem?

• We should update function isChatUsedForOnboarding so that it receives onboarding as the 2nd param. And then when using it:

App/src/components/LHNOptionsList/OptionRowLHN.tsx

Line 282 in 0e28aa4

{ReportUtils.isChatUsedForOnboarding(report) && <FreeTrial badgeStyles={[styles.mnh0, styles.pl2, styles.pr2, styles.ml1]} />}

should be:

                                                {ReportUtils.isChatUsedForOnboarding(report, onboarding) && <FreeTrial badgeStyles={[styles.mnh0, styles.pl2, styles.pr2, styles.ml1]} />}

with

    const [onboarding] = useOnyx(ONYXKEYS.NVP_ONBOARDING);

• Similar in here:
  

  App/src/pages/home/HeaderView.tsx

  Line 292 in 0e28aa4

  {!shouldUseNarrowLayout && isChatUsedForOnboarding && freeTrialButton}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• We should update isChatUsedForOnboarding function so that it will match the new isChatUsedForOnboarding version.

What alternative solutions did you explore? (Optional)

[twisterdotcom]

@truph01 this isn't external yet, and we will assign @c3024 after they comment here. Thanks for the proposal anyway!

[c3024]

Please assign me.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021864974056851982720

[melvin-bot]

Current assignee @c3024 is eligible for the External assigner, not assigning anyone new.

[iwiznia]

@c3024 any update here?

[c3024]

This issue arose because of moving the tasks to the #admins room for the “newDotManageTeam” intent. That PR was reverted because it uncovered a backend bug. This is being fixed in these PRs. The revert of this revert will be merged after the backend fixes are deployed.

So, I think we should hold this issue until #53661 is merged.

[thesahindia]

@twisterdotcom, I’m assigned as the reviewer for the PR, but I’m unsure if it requires a C+ reviewer. Please let me know.

[twisterdotcom]

Probably. Given the revert is done, does this still need to be held @c3024?

[c3024]

This can be removed from hold. I think a C+ review of the PR opened for this issue will be useful too.