Optimistic update for moving tasks for "Manage Team's Expenses" to #admins room #52314

c3024 · 2024-11-11T15:16:30Z

Explanation of Change

This PR moves the onboarding tasks to #admins room.

Fixed Issues

$ #51443
PROPOSAL: NA

Tests

Logon to ND with a new account.
Click on "Manage my team's expenses" intent on the onboarding flow and complete the onboarding.
Verify that the onboarding tasks show up in the #admins room.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

guideAndroid.mp4

Android: mWeb Chrome

Screenrecorder-2024-11-26-14-13-37-829.mp4

iOS: Native

guideiOS.mp4

iOS: mWeb Safari

guideiOSmWeb-compressed.mp4

MacOS: Chrome / Safari

guideChrome.mp4

MacOS: Desktop

guideDesktop.mp4

c3024 · 2024-11-12T16:32:04Z

moveTasksToAdminsRoom.mp4

yuwenmemon · 2024-11-12T18:45:26Z

src/libs/actions/Report.ts

@@ -3437,10 +3437,10 @@ function completeOnboarding(
    }

    const integrationName = userReportedIntegration ? CONST.ONBOARDING_ACCOUNTING_MAPPING[userReportedIntegration] : '';
-    const actorAccountID = CONST.ACCOUNT_ID.CONCIERGE;
-    const targetChatReport = ReportUtils.getChatByParticipants([actorAccountID, currentUserAccountID]);
+    const actorAccountID = engagementChoice === CONST.ONBOARDING_CHOICES.MANAGE_TEAM ? CONST.ACCOUNT_ID.QA_GUIDE : CONST.ACCOUNT_ID.CONCIERGE;


We don't use this, as discussed here https://expensify.slack.com/archives/C07HPDRELLD/p1731436691482209?thread_ts=1730777288.450589&cid=C07HPDRELLD

These are required for generating optimistic actions.

However, I will remove it from the params passed to CompleteGuidedSetup if it is not used in the backend.

Removing this from the params of the API request pushes the "Here are some important tasks" message generated from frontend below the tasks for some reason.

This reverts commit c0ee29f.

melvin-bot · 2024-11-19T06:35:17Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

c3024 · 2024-11-19T05:59:59Z

src/CONST.ts

@@ -2093,6 +2094,7 @@ const CONST = {
        NOTIFICATIONS: Number(Config?.EXPENSIFY_ACCOUNT_ID_NOTIFICATIONS ?? 11665625),
        PAYROLL: Number(Config?.EXPENSIFY_ACCOUNT_ID_PAYROLL ?? 9679724),
        QA: Number(Config?.EXPENSIFY_ACCOUNT_ID_QA ?? 3126513),
+        QA_GUIDE: Number(Config?.EXPENSIFY_ACCOUNT_ID_QA_GUIDE ?? 14365522),


This seems to be not a problem anymore. CreateWorkspace does not still return a personal detail for qa.guide. So, I retained this for the optimistic detail update.

We can use Concierge or currentUserAccountID instead of qa.guide for the optimistic report action generation. Backend overwrites these with qa.guide as the actor.

Can you try to use the guide's details that are sent along with their intro message following the call to CreatePolicy earlier in the guided setup flow?

When I checked this last time, CreateWorkspace was not returning qa.guide details. Let me check now again.

@yuwenmemon

CompleteGuidedSetup returns the assigned guide details. These optimistic task report actions etc. are created just after clicking on the accounting step and the assigned guide details are not available at that time.

The sender appears for the tasks as qa.guide briefly before they are replaced with the actual guide details sent in the response for CompleteGuidedSetup.

guideDetailOnCompleteGuidedSetup.mov

Look closer at that CreateWorkspace response. You should see that you have the email of the assigned guide:

Please do not use the qa.guide account as a placeholder. It is an internal testing account and should never be seen by the end user.

c3024 · 2024-11-19T06:05:51Z

src/pages/OnboardingEmployees/BaseOnboardingEmployees.tsx

@@ -43,6 +43,20 @@ function BaseOnboardingEmployees({shouldUseNativeStyles, route}: BaseOnboardingE
        });
    }, [translate, selectedCompanySize]);

+    const [allPersonalDetails] = useOnyx(ONYXKEYS.PERSONAL_DETAILS_LIST);
+
+    const setOptimticQAGuidePersonalDetail = () => {


This too is for the optimistic generation of report actions because CreateWorkspace's response still does not have the personal detail value for qa.guide. This can be omitted if we use Concierge or currentUserAccountID as the actor for the optimistic report actions. The actor is overwritten with qa.guide in backend's response.

c3024 · 2024-11-19T06:34:46Z

src/libs/actions/Report.ts

@@ -3437,10 +3437,10 @@ function completeOnboarding(
    }

    const integrationName = userReportedIntegration ? CONST.ONBOARDING_ACCOUNTING_MAPPING[userReportedIntegration] : '';
-    const actorAccountID = CONST.ACCOUNT_ID.CONCIERGE;
-    const targetChatReport = ReportUtils.getChatByParticipants([actorAccountID, currentUserAccountID]);
+    const actorAccountID = engagementChoice === CONST.ONBOARDING_CHOICES.MANAGE_TEAM ? CONST.ACCOUNT_ID.QA_GUIDE : CONST.ACCOUNT_ID.CONCIERGE;


Removing this from the params of the API request pushes the "Here are some important tasks" message generated from frontend below the tasks for some reason.

jjcoffee · 2024-11-19T10:51:42Z

@c3024 Is this ready for testing online or should I only be testing offline for now?

c3024 · 2024-11-19T11:06:30Z

This is ready for testing online too!

c3024 · 2024-11-26T09:59:21Z

@yuwenmemon
Thank you! Removed the QA guide placeholders. Now, using the guide details sent.

@jjcoffee
Uploaded all videos.

jjcoffee · 2024-11-26T15:49:35Z

I guess the only thing outstanding now is waiting for the BE change to accept whatever we send from FE to avoid duplication?

This will change shortly, and we'll send the updated message reflected in the mocks.

yuwenmemon · 2024-11-26T18:47:37Z

Let's send only the tasks in order to not have duplicates. Let the guide message come from the backend.

jjcoffee · 2024-11-27T09:07:27Z

src/components/LHNOptionsList/OptionRowLHN.tsx

+    const [introSelected] = useOnyx(ONYXKEYS.NVP_INTRO_SELECTED);
+    const session = useSession();
+
+    // A guide is assigned to the user if they choose the 'MANAGE_TEAM' onboarding option, except for users with emails containing '+'.


@c3024 I was thinking of something a bit more concise like "Guides are assigned for the MANAGE_TEAM onboarding action, except for emails that have +.". I think the rest is self-explanatory/easy to understand from a quick read of the code.

jjcoffee · 2024-11-27T09:08:54Z

src/libs/actions/Report.ts

@@ -3489,10 +3490,29 @@ function prepareOnboardingOptimisticData(
        }
    }

+    // A guide is assigned to the user if they choose the 'MANAGE_TEAM' onboarding option, except for users with emails containing '+'.


@c3024 Also could you make this one similarly more concise.

jjcoffee · 2024-11-27T09:21:37Z

@yuwenmemon Just to check the expected result, if we're offline before CreateWorkspace, here's what we'll get:

c3024 · 2024-11-27T10:32:47Z

@yuwenmemon Just to check the expected result, if we're offline before CreateWorkspace, here's what we'll get:

If we go offline before receiving the CreateWorkspace response, we do not have the guide's email. So, I used the "Setup Specialist" as the placeholder name for this case because I saw in some cases, the guide's name is shown as "Setup Specialist - <Guide's name>". Let me know if we wanna use a different placeholder.

jjcoffee

All good from my side, just this comment for you to check @yuwenmemon.

yuwenmemon · 2024-12-02T19:09:38Z

Think that's fine for now yeah!

OSBotify · 2024-12-02T19:18:12Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-12-02T22:02:15Z

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.0.70-0 🚀

platform	result
🤖 android 🤖	false ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

izarutskaya · 2024-12-03T10:19:16Z

@c3024 PR is fail with issue #53431

https://utest-dl.s3-accelerate.amazonaws.com/12102/26469/484909/6682554/bugAttachment/Bug6682554_1733192982196%21Screen_Recording_20241203_102616_Expensify.mp4?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Date=20241203T101847Z&X-Amz-SignedHeaders=host&X-Amz-Credential=AKIAJ2UIWMJ2OMC3UCQQ%2F20241203%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Expires=86400&X-Amz-Signature=41399135f9f2b08fce931cdbf6d00734ea6f43ea958b420a527b755795a61dea

github-actions · 2024-12-04T01:11:29Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.70-9 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

c3024 added 8 commits November 8, 2024 18:08

wip-move-tasks-to-admin-2

d95b51f

fix qa guide personal detail

bb9c312

Merge branch 'main' into wip-move-tasks-to-admin-2

d993935

troubleshoot LHN alternate text

d27f273

troubleshoot LHN alternate text

3b31e9f

Merge branch 'main' into wip-move-tasks-to-admin-2

7412464

fix optimistic lhn message for admins room

ff29d0d

fix lint

8872ba1

c3024 changed the title ~~[WIP] Optimistic update for moving tasks for "Manage Team's Expenses" to #admins room~~ Optimistic update for moving tasks for "Manage Team's Expenses" to #admins room Nov 12, 2024

c3024 added 2 commits November 12, 2024 21:29

rename QA_GUIDE

9b83bf7

fix lint

528b1ac

yuwenmemon requested changes Nov 12, 2024

View reviewed changes

c3024 added 5 commits November 15, 2024 08:23

Merge branch 'main' into wip-move-tasks-to-admin-2

3f3bf16

Merge branch 'main' into wip-move-tasks-to-admin-2

45b5d17

currentUserAccountID as actor

c0ee29f

Revert "currentUserAccountID as actor"

25801d2

This reverts commit c0ee29f.

remove redundant optimistic introduction message

b2b933d

c3024 marked this pull request as ready for review November 19, 2024 06:35

c3024 requested a review from a team as a code owner November 19, 2024 06:35

melvin-bot bot requested review from jjcoffee and removed request for a team November 19, 2024 06:35

c3024 commented Nov 19, 2024

View reviewed changes

c3024 added 3 commits November 19, 2024 17:35

remove introduction message

ff16699

retain existing introductory video

39dbcc7

Merge branch 'main' into wip-move-tasks-to-admin-2

1a6df41

This comment was marked as resolved.

Sign in to view

c3024 added 5 commits November 26, 2024 12:59

use guide email returned in CreatePolicy as actor

5ded7b7

prettier

34f5e1b

fix missing and unused values

de2b8b2

remove optimstic video to avoid duplication

6ec519f

remove duplication of messages

3d31534

jjcoffee reviewed Nov 27, 2024

View reviewed changes

c3024 added 2 commits November 27, 2024 15:43

Merge branch 'main' into wip-move-tasks-to-admin-2

d70d159

make comments concise

5c1618e

jjcoffee approved these changes Nov 27, 2024

View reviewed changes

melvin-bot bot requested a review from yuwenmemon November 27, 2024 10:37

yuwenmemon approved these changes Dec 2, 2024

View reviewed changes

yuwenmemon merged commit 473822d into Expensify:main Dec 2, 2024
18 checks passed

github-actions bot mentioned this pull request Dec 2, 2024

Deploy Checklist: New Expensify 2024-12-02 #53406

Closed

48 tasks

techievivek mentioned this pull request Dec 3, 2024

[HOLD for payment 2024-12-12] Android & iOS - App crashes after completing onboarding #53431

Closed

8 tasks

jjcoffee mentioned this pull request Dec 3, 2024

Onboarding - Onboarding tasks arenot moved to admins room in manage teams expenses #53450

Closed

8 tasks

melvin-bot bot mentioned this pull request Dec 4, 2024

[HOLD for payment 2024-12-20] [HOLD for payment 2024-12-11] [$250] Move onboarding tasks into the #admins room for admins #51443

Closed

6 tasks

yuwenmemon mentioned this pull request Dec 4, 2024

Revert "Optimistic update for moving tasks for "Manage Team's Expenses" to #admins room" #53598

Merged

This was referenced Dec 6, 2024

Revert revert moving tasks to admins room for "Manage my team expenses" intent #53661

Merged

[$250] Onboarding - "Start a free trial" banner and button appear in Concierge then disappear #53526

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Optimistic update for moving tasks for "Manage Team's Expenses" to #admins room #52314

Optimistic update for moving tasks for "Manage Team's Expenses" to #admins room #52314

c3024 commented Nov 11, 2024 •

edited

Loading

c3024 commented Nov 12, 2024

yuwenmemon Nov 12, 2024

c3024 Nov 12, 2024

c3024 Nov 19, 2024

melvin-bot bot commented Nov 19, 2024

c3024 Nov 19, 2024

yuwenmemon Nov 23, 2024

c3024 Nov 23, 2024

c3024 Nov 23, 2024 •

edited

Loading

c3024 Nov 23, 2024

yuwenmemon Nov 25, 2024

c3024 Nov 19, 2024

c3024 Nov 19, 2024

jjcoffee commented Nov 19, 2024

c3024 commented Nov 19, 2024

This comment was marked as resolved.

c3024 commented Nov 26, 2024

jjcoffee commented Nov 26, 2024

yuwenmemon commented Nov 26, 2024

jjcoffee Nov 27, 2024

c3024 Nov 27, 2024

jjcoffee Nov 27, 2024

jjcoffee commented Nov 27, 2024

c3024 commented Nov 27, 2024

jjcoffee left a comment

yuwenmemon commented Dec 2, 2024

OSBotify commented Dec 2, 2024

github-actions bot commented Dec 2, 2024

izarutskaya commented Dec 3, 2024 •

edited

Loading

github-actions bot commented Dec 4, 2024

Optimistic update for moving tasks for "Manage Team's Expenses" to #admins room #52314

Optimistic update for moving tasks for "Manage Team's Expenses" to #admins room #52314

Conversation

c3024 commented Nov 11, 2024 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

c3024 commented Nov 12, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

melvin-bot bot commented Nov 19, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

c3024 Nov 23, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jjcoffee commented Nov 19, 2024

c3024 commented Nov 19, 2024

This comment was marked as resolved.

c3024 commented Nov 26, 2024

jjcoffee commented Nov 26, 2024

yuwenmemon commented Nov 26, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jjcoffee commented Nov 27, 2024

c3024 commented Nov 27, 2024

jjcoffee left a comment

Choose a reason for hiding this comment

yuwenmemon commented Dec 2, 2024

OSBotify commented Dec 2, 2024

github-actions bot commented Dec 2, 2024

izarutskaya commented Dec 3, 2024 • edited Loading

github-actions bot commented Dec 4, 2024

c3024 commented Nov 11, 2024 •

edited

Loading

c3024 Nov 23, 2024 •

edited

Loading

izarutskaya commented Dec 3, 2024 •

edited

Loading