[HOLD for payment 2024-12-19] Fix the pusher instance not found crash

[mountiny]

We are seeing this specific crash error in firebase that we have not been able to easily reproduce but we can see that its happening:

   Fatal Exception: com.facebook.react.common.JavascriptException: Error: TaskQueue: Error with task : [Pusher] instance not found. Pusher.subscribe()
            most likely has been called before Pusher.init(), js engine: hermes, stack:
anonymous@1:3767030
processNext@1:847707
_processUpdate@1:846412
anonymous@1:524811
_callTimer@1:523728
_callReactNativeMicrotasksPass@1:523929
callReactNativeMicrotasks@1:525881
__callReactNativeMicrotasks@1:218344
anonymous@1:216543
__guard@1:218218
flushedQueue@1:216454
callFunctionReturnFlushedQueue@1:216310

       at com.facebook.react.modules.core.ExceptionsManagerModule.reportException(ExceptionsManagerModule.java:65)
       at com.facebook.jni.NativeRunnable.run(NativeRunnable.java)
       at android.os.Handler.handleCallback(Handler.java:958)
       at android.os.Handler.dispatchMessage(Handler.java:99)
       at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:27)
       at android.os.Looper.loopOnce(Looper.java:230)
       at android.os.Looper.loop(Looper.java:319)
       at com.facebook.react.bridge.queue.MessageQueueThreadImpl$4.run(MessageQueueThreadImpl.java:235)
       at java.lang.Thread.run(Thread.java:1012)

Here is a link to firebase for the crash

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[jnowakow]

Hello, I'm from SoftwareMansion and I'll work on this issue

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.74-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Subscribe to Pusher only when it's initialized #53751

If no regressions arise, payment will be issued on 2024-12-19. 🎊

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests
• @jnowakow does not require payment (Contractor)

[melvin-bot]

@allroundexperts @mallenexpensify @allroundexperts The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[s77rt]

Hey, I think the PR fixing this caused #54142. Please take a look 👀

[mountiny]

$125 for @allroundexperts as there was a regression from this PR

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @allroundexperts owed $250 via NewDot
• Contributor: @jnowakow is from an agency-contributor and not due payment

BugZero Checklist (@mallenexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[mallenexpensify]

Contributor+: @allroundexperts due $125 via NewDot

Do we want a test case for this? Or one updated?

[melvin-bot]

@mallenexpensify, @allroundexperts, @mountiny, @jnowakow Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[allroundexperts]

I don't think we need a test case for this. In the PR, the test steps just mentioned opening the app and verifying if it crashed or not.