Subscribe to Pusher only when it's initialized #53751

jnowakow · 2024-12-09T12:56:43Z

Explanation of Change

It may happen that we subscribe to Pusher channel before Pusher finished initialisation. Pusher is initialised in AuthScreens. We subscribe to it across the app, for example on ReportScreen. Opening ReportScreen directly (for example through deep link) may result in crash with error: fatal Exception: com.facebook.react.common.JavascriptException: Error: TaskQueue: Error with task : [Pusher] instance not found. Pusher.subscribe() most likely has been called before Pusher.init(), .... Thanks to this change we are sure that in the moment we subscribe to Pusher it's initialisation is already finished.

Fixed Issues

$ #53752
PROPOSAL: N/A

Link to slack conversation

Tests

Open Report Screen from deep link.
Verify that app doesn't crash.

Verify that no errors appear in the JS console

Offline tests

Same as tests.

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

No visual changes are made so there are no recordings.

Screenshots/Videos

Android: Native

N/A

Android: mWeb Chrome

N/A

iOS: Native

N/A

iOS: mWeb Safari

N/A

MacOS: Chrome / Safari

N/A

MacOS: Desktop

N/A

jnowakow · 2024-12-09T12:57:10Z

cc @mountiny

melvin-bot · 2024-12-09T12:57:14Z

@amyevans Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2024-12-09T13:11:21Z

🚧 @mountiny has triggered a test build. You can view the workflow run here.

allroundexperts · 2024-12-09T13:11:29Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-12-09.at.8.57.02.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-12-09.at.8.54.50.PM.mov

iOS: Native

Screen.Recording.2024-12-09.at.8.54.08.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-12-09.at.8.45.41.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-12-09.at.8.31.47.PM.mov

MacOS: Desktop

Screen.Recording.2024-12-09.at.8.39.20.PM.mov

github-actions · 2024-12-09T13:37:20Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/53751/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/53751/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/53751/NewExpensify.dmg	https://53751.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

mountiny · 2024-12-09T15:57:26Z

@allroundexperts what is your ETA for the checklist?

allroundexperts · 2024-12-09T15:58:40Z

@allroundexperts what is your ETA for the checklist?

5 minutes 😄

mountiny · 2024-12-09T15:59:05Z

counting

allroundexperts

Works good!

mountiny · 2024-12-09T16:10:59Z

Seems like you made it

mountiny

makes sense to me, all yours @amyevans

mountiny · 2024-12-09T16:40:37Z

Chatted with Amy briefly and I can go ahead

OSBotify · 2024-12-09T16:49:19Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-12-10T23:04:45Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.74-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-12T01:34:42Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.74-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

Subscribe to Pusher only when it's initialized

4ba267d

jnowakow requested a review from a team as a code owner December 9, 2024 12:56

melvin-bot bot requested a review from amyevans December 9, 2024 12:57

melvin-bot bot removed the request for review from a team December 9, 2024 12:57

mountiny assigned jnowakow Dec 9, 2024

mountiny added the Ready To Build label Dec 9, 2024

mountiny requested a review from allroundexperts December 9, 2024 13:11

mountiny self-requested a review December 9, 2024 13:11

Fix tests

f2090bf

allroundexperts approved these changes Dec 9, 2024

View reviewed changes

mountiny approved these changes Dec 9, 2024

View reviewed changes

mountiny merged commit f5234f7 into Expensify:main Dec 9, 2024
17 checks passed

github-actions bot mentioned this pull request Dec 10, 2024

Deploy Checklist: New Expensify 2024-12-10 #53889

Closed

52 tasks

melvin-bot bot mentioned this pull request Dec 12, 2024

[HOLD for payment 2024-12-19] Fix the pusher instance not found crash #53752

Open

s77rt mentioned this pull request Dec 14, 2024

[HOLD for payment 2024-12-30] NewDot application on staging consistently shows the error message "Uh-oh, something went wrong!" whenever it refreshes, either automatically in the background or through a manual refresh. #54142

Open

8 tasks

jnowakow mentioned this pull request Dec 16, 2024

Initialise pusher before rendering children #54188

Merged

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Subscribe to Pusher only when it's initialized #53751

Subscribe to Pusher only when it's initialized #53751

jnowakow commented Dec 9, 2024 •

edited

Loading

jnowakow commented Dec 9, 2024

melvin-bot bot commented Dec 9, 2024

github-actions bot commented Dec 9, 2024

allroundexperts commented Dec 9, 2024 •

edited

Loading

github-actions bot commented Dec 9, 2024

mountiny commented Dec 9, 2024

allroundexperts commented Dec 9, 2024

mountiny commented Dec 9, 2024

allroundexperts left a comment

mountiny commented Dec 9, 2024

mountiny left a comment

mountiny commented Dec 9, 2024

OSBotify commented Dec 9, 2024

github-actions bot commented Dec 10, 2024

github-actions bot commented Dec 12, 2024

Subscribe to Pusher only when it's initialized #53751

Subscribe to Pusher only when it's initialized #53751

Conversation

jnowakow commented Dec 9, 2024 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

jnowakow commented Dec 9, 2024

melvin-bot bot commented Dec 9, 2024

github-actions bot commented Dec 9, 2024

allroundexperts commented Dec 9, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

github-actions bot commented Dec 9, 2024

mountiny commented Dec 9, 2024

allroundexperts commented Dec 9, 2024

mountiny commented Dec 9, 2024

allroundexperts left a comment

Choose a reason for hiding this comment

mountiny commented Dec 9, 2024

mountiny left a comment

Choose a reason for hiding this comment

mountiny commented Dec 9, 2024

OSBotify commented Dec 9, 2024

github-actions bot commented Dec 10, 2024

github-actions bot commented Dec 12, 2024

jnowakow commented Dec 9, 2024 •

edited

Loading

allroundexperts commented Dec 9, 2024 •

edited

Loading