Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open E.cash to non-developers #1444

Merged
merged 6 commits into from
Mar 15, 2021
Merged

Open E.cash to non-developers #1444

merged 6 commits into from
Mar 15, 2021

Conversation

stitesExpensify
Copy link
Contributor

@stitesExpensify stitesExpensify commented Feb 9, 2021 •
edited
Loading

Details

This PR:

  1. Removes the page from the sign-in flow where we were taking github usernames
  2. Removes login checks that required a github username
  3. Remove all the checks for canAccessExpensify which were blocking users without a GH or shared chat report

Fixed Issues

Fixes
https://github.com/Expensify/Expensify/issues/149098
https://github.com/Expensify/Expensify/issues/155153

Tests

  1. Create a new account
  2. Make sure you are not asked for your GH username
  3. Make sure you get a validation email
  4. Click the email and make sure it sends you to e.cash (not e.com)
  5. Log out and make sure you can log in normally
  6. Log out and make sure you can log into an existing account

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

2021-03-11_13-11-53
2021-03-11_09-37-00

@stitesExpensify stitesExpensify requested a review from a team as a code owner February 9, 2021 22:37
@stitesExpensify stitesExpensify self-assigned this Feb 9, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@botify botify requested review from TomatoToaster and removed request for a team February 9, 2021 22:37
@stitesExpensify stitesExpensify removed the request for review from TomatoToaster February 9, 2021 22:38
@stitesExpensify stitesExpensify changed the title [HOLD] Open E.cash to non-developers Open E.cash to non-developers Mar 11, 2021
@stitesExpensify stitesExpensify requested a review from a team March 11, 2021 22:26
@stitesExpensify
Copy link
Contributor Author

stitesExpensify commented Mar 11, 2021 •
edited
Loading

cc: @tgolen since you did a lot of this with me originally

@botify botify requested review from alex-mechler and removed request for a team March 11, 2021 22:27
alex-mechler
alex-mechler reviewed Mar 12, 2021
View reviewed changes
Copy link
Contributor

@alex-mechler alex-mechler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, should this be on hold at all or are we ready for e.cash to be public? The only discussion I saw about it is that is was ready to go into review, but it didnt mention if we were ready to make e.cash open to the public.

src/pages/signin/LoginForm/LoginFormNarrow.js Outdated Show resolved Hide resolved
src/pages/signin/LoginForm/LoginFormWide.js Outdated Show resolved Hide resolved
@stitesExpensify
Copy link
Contributor Author

Also, should this be on hold at all or are we ready for e.cash to be public? The only discussion I saw about it is that is was ready to go into review, but it didnt mention if we were ready to make e.cash open to the public.

Nope we are full send! Went off hold today 😄

@stitesExpensify
Copy link
Contributor Author

https://expensify.slack.com/archives/C011W8BJ9L6/p1615501461160900?thread_ts=1615390233.108000&cid=C011W8BJ9L6

alex-mechler
alex-mechler approved these changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@alex-mechler alex-mechler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would love to also have @tgolen review this since it's been a while since I've been in this codebase

src/libs/API.js Show resolved Hide resolved
@alex-mechler alex-mechler requested a review from tgolen March 12, 2021 17:07
@stitesExpensify
Copy link
Contributor Author

Going to pull master and make sure this still works given the react-navigation update. Should be fine but I want to double check

@stitesExpensify
Copy link
Contributor Author

Yep still works!

@tgolen tgolen merged commit dbb7932 into master Mar 15, 2021
@tgolen tgolen deleted the stites-removeGithubRequirement branch March 15, 2021 16:34
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alex-mechler alex-mechler alex-mechler approved these changes

@tgolen tgolen tgolen approved these changes

Assignees

@stitesExpensify stitesExpensify

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stitesExpensify @tgolen @alex-mechler