-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix android status bar color #15471
Closed
Closed
Fix android status bar color #15471
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3d392d6
Fix status bar not matching background on Android
roryabraham a223dab
Add comment
roryabraham 6d4ee6c
Remove redundant styles in BootTheme
roryabraham 776f1da
Remove unnecessary styles from BootTheme
roryabraham 37e720e
Fix black icons in status bar
roryabraham d5cc9a7
Replace RN SafeAreaView with SafeAreaView from react-native-safe-area…
roryabraham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,21 +1,20 @@ | ||
<resources xmlns:tools="http://schemas.android.com/tools"> | ||
|
||
<!-- App Theme for Android versions 7.1 and below --> | ||
<style name="AppTheme" parent="BaseAppTheme"/> | ||
|
||
<!-- Base application theme. Applied to all Android versions --> | ||
<style name="BaseAppTheme" parent="Theme.AppCompat.NoActionBar"> | ||
<item name="android:colorEdgeEffect">@color/gray4</item> | ||
<item name="android:statusBarColor">#061B09</item> | ||
<item name="android:navigationBarColor">@android:color/transparent</item> | ||
<item name="android:statusBarColor">@android:color/transparent</item> | ||
<item name="colorAccent">@color/accent</item> | ||
<item name="android:editTextBackground">@drawable/rn_edit_text_material</item> | ||
</style> | ||
|
||
<!-- App Theme for Android versions 7.1 and below --> | ||
<style name="AppTheme" parent="BaseAppTheme"/> | ||
|
||
<!-- Themes unique to the boot splash page --> | ||
<style name="BootTheme" parent="AppTheme"> | ||
<item name="android:background">@drawable/bootsplash</item> | ||
<item name="android:windowTranslucentStatus">false</item> | ||
<item name="android:fitsSystemWindows">true</item> | ||
</style> | ||
|
||
</resources> |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to do this programmatically, it's less obvious and hard to find IMO. Instead, let's use the style attribute (suggested below).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I take this back. Seems like it is necessary because React Native doesn't use Android layouts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A problem with React native not letting us modify the Android layout is that adding padding to our outermost layout (to solve the overlapping issue) is problematic. I think we'll need to do this: