Fix ESLint network requests #1674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasperhuangg
approved these changes
Mar 9, 2021
|
@jasperhuangg I think it's probably fine this time, but just FYI you generally don't want to merge code if there's still a pending reviewer (unless you check with them first or they're ooo or something). |
|
Thanks, I was fixing these over here already 🙃 #1671 |
|
@roryabraham |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
There are lint errors on master. In this PR, the
API.requestmethod was removed, and the change was missed when another PR was merged.Fixed Issues
n/a, but my pre-commit hook won't let me commit anything while there are lint errors, so here we are :)
Tests
cc @NikkiWines - I think these functions are related to the user settings menu. I ran the app and everything seemed to work fine without errors, so we should be good 🤷🏼♂️
Tested On