Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create formatPhoneNumber util function #16804
feat: create formatPhoneNumber util function #16804
Changes from all commits
b74f718
ce4ffb3
40bf1d5
e0723b0
6dd8c32
acad88e
3e0981e
89212a8
d2ed3e0
985ac9f
30b9069
e5018ba
fc4a29c
cdb5889
65911fd
05c340b
07ebc76
0a3a503
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't this make it so that their displayName will show up as their phone number even if they have a name set. For example, if I have my primary login on my account as
1234567890
and my display name asPuneet Lath
this will make it so that my display name shows as(123) 456-7890
. I think we only want it to show as that if I don't have a display name set.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@puneetlath It is the current behavior, I just moved the condition up and changed the formatting number function for a new one. I can ofc add a check if there is a name and display it instead of the phone number, but should it be done in this issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, looks like it's the current behavior and we shouldn't do anything about it in this issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok got it. Let's handle separately then.
@koko57 would you want to raise a separate PR for that fix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@koko57 if you don't have the time / different priorities, I can create a tracking issue and the PR.
Just let me know
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rushatgabhane I can take it :) So if you create an issue, please assign me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was trying to get screenshots for the issue but I don't have an account with phone as the primary login.
I'm traveling and expensify isn't allowing me to create an account with phone number from another country
@puneetlath could you help us out 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need an account you can sign in with or just one you can message? If you just need to message one, you can message my +19726585619 account. I can take care of any tests that require logging in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I sent you a message and I can't see a display name.
Please confirm that you have a name set on that account, and I'll create an issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just responded!