-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New GH Action: CreateOrUpdateStagingDeployCash #1703
Conversation
@@ -299,7 +301,7 @@ class GithubUtils { | |||
deployBlockers = [], | |||
resolvedDeployBlockers = [], | |||
) { | |||
return this.generateVersionComparisonURL(`${GITHUB_OWNER}/${EXPENSIFY_CASH_REPO}`, tag, 'BUILD') | |||
return this.generateVersionComparisonURL(`${GITHUB_OWNER}/${EXPENSIFY_CASH_REPO}`, tag, 'PATCH') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before a StagingDeployCash
is finalized, QAd, and deployed to production, we'll bump the PATCH
(required for mobile prod deploy). So we'll want a comparison between the current BUILD
version (what's currently on staging/included in the StagingDeployCash
), and the previous PATCH
version (what's currently in production).
# Conflicts: # tests/unit/GithubUtilsTest.js
Okay, got pretty far with this. I think right now it's failing to create the action because we're listing |
# Conflicts: # tests/unit/GithubUtilsTest.js
Just for ease of record-keeping, this is how this was tested: - name: Create or Update StagingDeployCash
uses: Expensify/Expensify.cash/.github/actions/createOrUpdateStagingDeploy@74b813a5ae14aa327319d49ef6d87a21ab6d75db
with:
NPM_VERSION: '1.0.2-25'
GITHUB_TOKEN: ${{ secrets.OS_BOTIFY_TOKEN }}
NEW_PULL_REQUESTS: 'https://github.com/Expensify/Expensify.cash/pull/1,https://github.com/Expensify/Expensify.cash/pull/2'
NEW_DEPLOY_BLOCKERS: 'https://github.com/Expensify/Expensify.cash/issues/123,https://github.com/Expensify/Expensify/issues/12345' And when the issue was first created, this was the result: As expected, the |
Okay, had to fix a couple more bugs but now the update part is working too: |
Okay, this PR is now ready for review 👍 |
# Conflicts: # tests/unit/GithubUtilsTest.js
This issue is currently HELD on https://github.com/Expensify/Expensify/issues/157003
Details
Implements a new Github Action to create or update the StagingDeployCash issue.
Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/155140
Tests
StagingDeployCash
✅ Test StagingDeployCash #1712StagingDeployCash
✅Tested On