Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deployBlocker action #1758

Merged
merged 6 commits into from
Mar 13, 2021
Merged

Add deployBlocker action #1758

merged 6 commits into from
Mar 13, 2021

Conversation

AndrewGable
Copy link
Contributor

Details

Adds a deploy blocker action as described in the issue: https://github.com/Expensify/Expensify/issues/156481. It will listen for the DeployBlockerCash label then add it to the open staging deploy issue.

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/156481

Tests

  1. Merge this PR
  2. Apply the DeployBlockerCash label to this PR
  3. Verify it's added to the deploy blocker list here: Deploy Checklist: Expensify.cash 2021-03-11 #1732
  4. Add a DeployBlockerCash to an issue
  5. Verify it's added to the deploy blocker list here: Deploy Checklist: Expensify.cash 2021-03-11 #1732

@AndrewGable AndrewGable requested a review from roryabraham March 13, 2021 00:20
@AndrewGable AndrewGable requested a review from a team as a code owner March 13, 2021 00:20
@AndrewGable AndrewGable self-assigned this Mar 13, 2021
@botify botify requested review from robertjchen and removed request for a team and robertjchen March 13, 2021 00:21
roryabraham
roryabraham requested changes Mar 13, 2021
View reviewed changes
.github/workflows/deployBlocker.yml Outdated
if: ${{ github.event_name == 'issues' }}
with:
GITHUB_TOKEN: ${{ secrets.OS_BOTIFY_TOKEN }}
NEW_PULL_REQUESTS: ${{ github.event.issue.url }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooo I think you might need to use the html_url here so it doesn't use the API base URL

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch, agree

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the difference:

image

roryabraham
roryabraham approved these changes Mar 13, 2021
View reviewed changes
Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@roryabraham roryabraham merged commit e5556fb into master Mar 13, 2021
@roryabraham roryabraham deleted the andrew-deploy-blocker branch March 13, 2021 00:42
@botify
Copy link

botify commented Mar 13, 2021

@roryabraham looks like this was merged without passing tests. Please add a note explaining why this was done or remove the Emergency label if this is not an emergency.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2021
@roryabraham
Copy link
Contributor

Trying to prevent version workflows from failing.

@roryabraham
Copy link
Contributor

Nice, it worked 🎉 https://github.com/Expensify/Expensify.cash/runs/2099890339?check_suite_focus=true

@AndrewGable AndrewGable added DeployBlockerCash This issue or pull request should block deployment and removed DeployBlockerCash This issue or pull request should block deployment labels Mar 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roryabraham roryabraham roryabraham approved these changes

@robertjchen robertjchen Awaiting requested review from robertjchen

Assignees

@AndrewGable AndrewGable

Labels
DeployBlockerCash This issue or pull request should block deployment Emergency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndrewGable @botify @roryabraham