Fix react navigation issues with IOUModal #1771
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixes a couple of issues related to the IOUModal pages and the recent React-native-navigation implementation:
<ScreenWrapper>
, fixing the status bar margin on mobile and aligning with other Modalslocalhost/iou/request
shows a grey background, as this doesn't occur when users use the navigation routing (should investigate this later)Fixed Issues
Fixes #1769
Tests
Save the following diff as
diff.txt
and apply withgit apply diff.txt
(make sure you include the empty new line!)Confirm close button now works
Confirm header does not overlap the status bar
Example of existing problem:
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android